Closed Bug 1194962 Opened 9 years ago Closed 9 years ago

Remove border-radius from the identity box

Categories

(Firefox :: Theme, defect)

Unspecified
Windows
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: dao, Assigned: martianwars, Mentored)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 file, 1 obsolete file)

http://hg.mozilla.org/mozilla-central/annotate/2ddfc9180971/browser/themes/windows/browser.css#l1456

This was meant to accommodate to the location bar's border-radius, but that border-radius is only 1px now which means that the inner edge of the border is pretty much rectangular. So the identity box should be rectangular too.

Note that this is only visible in popup windows.
Hi :dao, I am interested in this bug. Could I work on it? I have submitted a patch earlier but it hasn't been approved as yet. It wasn't mentored either.
(In reply to Kalpesh Krishna from comment #1)
> Hi :dao, I am interested in this bug. Could I work on it?

Sure!
So I have to simply remove all four border radius attributes right?
(In reply to Kalpesh Krishna from comment #3)
> So I have to simply remove all four border radius attributes right?

yes
Attached patch cssfixborder.patch (obsolete) — Splinter Review
Attachment #8648472 - Flags: review?(dao)
Comment on attachment 8648472 [details] [diff] [review]
cssfixborder.patch

> #identity-box:-moz-locale-dir(ltr) {
>-  border-top-left-radius: 1.5px;
>-  border-bottom-left-radius: 1.5px;
> }
> 
> #identity-box:-moz-locale-dir(rtl) {
>-  border-top-right-radius: 1.5px;
>-  border-bottom-right-radius: 1.5px;
> }


Please remove both rules entirely.
Attachment #8648472 - Flags: review?(dao)
Attachment #8648513 - Flags: review?(dao)
Comment on attachment 8648513 [details] [diff] [review]
cssborderfix.patch

Thanks!
Attachment #8648513 - Flags: review?(dao) → review+
Assignee: nobody → kalpeshk2011
Attachment #8648472 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/6abcc952af87
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.