1194991 - Coercions to restricted float values are wrong in WebIDL.py

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[n.oxyde]

Attachment: Fix for IDLValue.coerceToType()

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/600.1.17 (KHTML, like Gecko) Version/7.1 Safari/537.85.10

Steps to reproduce:

Call IDLValue.coerceToType() on a float or integer value with a float or double type.


Actual results:

The coerced value does not refer to the intended restricted float or double type. integer.coerceToType(float_or_double_type) always returns a restricted float. float_or_double.coerceToType(restricted_float_or_double_type) always returns the same type as float_or_double.


Expected results:

The coerced value's type should always be the one passed as argument.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8648384 [details] [diff] [review]
Fix for IDLValue.coerceToType()

Came up in Servo, where restricted and unrestricted floats have different types.

Comment 2

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Can you add a test for somewhere in Gecko that this distinction matters?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I don't think it matters in Gecko. Maybe a test under dom/bindings/parser/tests/ would work. nox, you want to try writing one?

Comment 4

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Is this just waiting on the test to be checked in?

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yeah, I guess. Completely forgot about this bug.

Comment 6

[n.oxyde]

I would be happy if someone else does it. I just remembered about it right now trying to update the parser in Servo.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: rewrite test_const.py to simplify adding new tests

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: coerce WebIDL constants to the correct type

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e6be8988177
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1966d9bbf47

Comment 10

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/4e6be8988177
https://hg.mozilla.org/mozilla-central/rev/f1966d9bbf47