Closed Bug 1195063 Opened 6 years ago Closed 6 years ago

Create a UI Settings option for changing the image threshold image size for click-to-play images

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox44 verified)

VERIFIED FIXED
Firefox 44
Tracking Status
firefox44 --- verified

People

(Reporter: jonalmeida, Assigned: jonalmeida)

References

Details

Attachments

(3 files, 1 obsolete file)

This bug is to track the UI option that needs to be included for enabling the click-to-play image.

One option is to have a checkbox that enables/disables the feature (with the option to have an hardcoded image dimensions or file size that would be allowed, so that smaller images will still be seen.

A second option is having a slider or textview for the size of the image (in KB) which would determine if we should block the image or not.
Attached image option-1.png (obsolete) —
A prototype screenshot of what option 1 would look like.
Attached patch option-1.patchSplinter Review
The patch for option-1.png
antlam can help us figure out where this should go in settings, and what it should look like.
I think a simple enable/disable is a good "v1". 

We do need to clean up the copy though. This is another one of those "check this box to not do that" types and it's not really ideal. I think there's also potential overlap with bug 1192075 in terms of keeping copy style's consistent. I'll need to mull this over a bit.

That being said, I've some questions (for you Jon) about this slider UI. You mentioned we could think about a slider. What data points/ variables do we have at our disposal for this? i.e. if there's a slider, what can I allow the user to "slide"? image size? image dimension? number of images?
Flags: needinfo?(jalmeida)
Similar to bug 1192075 's

> Magnify small areas
> Enlarge links and form fields when tapping near them

Perhaps: 

Tap-to-load images
Save bandwidth by loading images only when you tap on them

Matej, care to give this a quick pass over? :)
Flags: needinfo?(matej)
(In reply to Anthony Lam (:antlam) from comment #5)
> Similar to bug 1192075 's
> 
> > Magnify small areas
> > Enlarge links and form fields when tapping near them
> 
> Perhaps: 
> 
> Tap-to-load images
> Save bandwidth by loading images only when you tap on them
> 
> Matej, care to give this a quick pass over? :)

Looks good, I just wonder if we need "save bandwidth." I know that gives context and a "why," but it reads more like the other one without it:

Tap-to-load images
Load images only when you tap on them
Flags: needinfo?(matej)
(In reply to Jonathan Almeida (:jonalmeida) from comment #0)
> This bug is to track the UI option that needs to be included for enabling
> the click-to-play image.
> 
> One option is to have a checkbox that enables/disables the feature (with the
> option to have an hardcoded image dimensions or file size that would be
> allowed, so that smaller images will still be seen.

We could change the checkbox to a list:
[Always load images]
[Load images only when you tap on them]
[Never load images]

> A second option is having a slider or textview for the size of the image (in
> KB) which would determine if we should block the image or not.

I think a slider would be a nightmare for users. If we want to allow small images to not be blocked, we should just do it. No UI.
(In reply to Matej Novak [:matej] from comment #6)
> (In reply to Anthony Lam (:antlam) from comment #5)
> > Similar to bug 1192075 's
> > 
> > > Magnify small areas
> > > Enlarge links and form fields when tapping near them
> > 
> > Perhaps: 
> > 
> > Tap-to-load images
> > Save bandwidth by loading images only when you tap on them
> > 
> > Matej, care to give this a quick pass over? :)
> 
> Looks good, I just wonder if we need "save bandwidth." I know that gives
> context and a "why," but it reads more like the other one without it:
> 
> Tap-to-load images
> Load images only when you tap on them

Yeah I was debating that, but I figured it might be a "quick win". This wfm though - thanks!

(In reply to Mark Finkle (:mfinkle) from comment #7)
> (In reply to Jonathan Almeida (:jonalmeida) from comment #0)
> > This bug is to track the UI option that needs to be included for enabling
> > the click-to-play image.
> > 
> > One option is to have a checkbox that enables/disables the feature (with the
> > option to have an hardcoded image dimensions or file size that would be
> > allowed, so that smaller images will still be seen.
> 
> We could change the checkbox to a list:
> [Always load images]
> [Load images only when you tap on them]
> [Never load images]

I think a simple on/off would be a good, simple start. We should ideally be more strict about giving users TOO many decisions to make.

We can keep the long-press for choose to load an image. After trying the build, I found that image links are far too common and the single-press is best kept for "tapping" (I.e. a link)

> > A second option is having a slider or textview for the size of the image (in
> > KB) which would determine if we should block the image or not.
> 
> I think a slider would be a nightmare for users. If we want to allow small
> images to not be blocked, we should just do it. No UI.

Agree.
(In reply to Anthony Lam (:antlam) from comment #4)
> That being said, I've some questions (for you Jon) about this slider UI. You
> mentioned we could think about a slider. What data points/ variables do we
> have at our disposal for this? i.e. if there's a slider, what can I allow
> the user to "slide"? image size? image dimension? number of images?

So I was looking into this since I wasn't sure what I had available. For now, I can only get the width and height easily from the image. This is helpful from the last bit of discussion so far, since I use this to allow images below a 64x64 dimension or some other arbitrary value.
Flags: needinfo?(jalmeida)
(In reply to Jonathan Almeida (:jonalmeida) from comment #9)
> So I was looking into this since I wasn't sure what I had available. For
> now, I can only get the width and height easily from the image. This is
> helpful from the last bit of discussion so far, since I use this to allow
> images below a 64x64 dimension or some other arbitrary value.

Thanks for looking into this! Something to keep in mind I think. For the time being, a simple on/off would suffice :)
Attached image option-1.png
Updated screenshot with correct place in Settings and new text.
Assignee: nobody → jalmeida
Attachment #8648459 - Attachment is obsolete: true
Bug 1195063 - Create a UI Settings option for changing the image threshold image size for click-to-play images r?mfinkle
Attachment #8655118 - Flags: review?(mark.finkle)
Comment on attachment 8655118 [details]
MozReview Request: Bug 1195063 - Create a UI Settings option for changing the image threshold image size for click-to-play images r?mfinkle

Bug 1195063 - Create a UI Settings option for changing the image threshold image size for click-to-play images r?mfinkle
Added nightly flag from review at comment 47 in bug 1170725
Comment on attachment 8655118 [details]
MozReview Request: Bug 1195063 - Create a UI Settings option for changing the image threshold image size for click-to-play images r?mfinkle

https://reviewboard.mozilla.org/r/17833/#review18403

Looks good
Attachment #8655118 - Flags: review?(mark.finkle) → review+
I pushed a try build with the click-to-play images commit as well since the UI bit requires it (even though it compiles and runs without it).
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a05527bf071a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Blocks: 1210129
Blocks: 1170725
No longer depends on: 1170725
Verified as fixed in build 44.0a1 2015-10-09;
Device: Motorola Razr (Android 4.4.4).
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.