1195083 - create a new mozregression.network module

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

See bug 1195079 for details.

tests must be moved also, and GUI must be updated probably to work.

Comment 1

[MikeLing]

Hi Julien,

I just follow the bug 1195079 to here, and work like to work on this. 

I think, generally, we just need to put create a new file named network.py and move retry_get, set_http_cache_session, get_http_session, url_links method into it, then rewrite the test and related import part.

Please tell me if anything I missed or misinterpret. Thank you :)

Comment 2

[Julien Pagès (:parkouss)]

Yep, this is what we need. :)

The tests related to each functions should be moved in a new file test_network.py.

You have to ensure that the tests are still passing after the work - and please check the GUI also as there is some imports that you may need to change in there.

Comment 3

[MikeLing]

(In reply to Julien Pagès from comment #2)

ok, I will try to commit my first pr tomorrow. If we should I know how to deal with whole bunch of things(move code, change relate, move test,etc). I will take the other pr as well. :)

Comment 4

[MikeLing]

Attachment: PR for bug 1195083

All test has been passed on github, and I also test it locally. It seems like works fine :)

Comment 5

[Julien Pagès (:parkouss)]

Comment on attachment 8648544 [details] [review]
PR for bug 1195083

Yep, looks good and seems to work fine for me too. :)

Thanks!

Comment 6

[Julien Pagès (:parkouss)]

Landed in https://github.com/mozilla/mozregression/commit/b9398c7a5355d13e01ba9b9966967b6b3fec2d0e.