Closed Bug 1195089 Opened 4 years ago Closed 4 years ago

Building bootable images for device without a device tree (dt.img) for the kernel fails

Categories

(Firefox OS Graveyard :: B2gInstaller, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S5 (21Aug)

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

PR
51 bytes, text/x-github-pull-request
daleharvey
: review+
Details | Review
> Building bootable image /tmp/b2g-installer/aries/content/BOOT /tmp/b2g-installer/aries/images/boot.img about.js:213:3
> This device hasDeviceTree?  false

So we properly detect we have no dt.img, but ...

> Prepared options Object { kernel: "/tmp/b2g-installer/aries/content/BO…", ramdisk: "/tmp/b2g-installer/aries/content/BO…", dt: "/tmp/b2g-installer/aries/content/BO…", output: "/tmp/b2g-installer/aries/images/boo…", cmdline: "androidboot.hardware=qcom user_debu…", pagesize: "2048", base: "0x00000000" }

We still pass it to the build process :(
Attached file PR
Assignee: nobody → lissyx+mozillians
Status: NEW → ASSIGNED
Attachment #8648461 - Flags: review?(dale)
Whiteboard: [systemsfe]
Target Milestone: --- → FxOS-S5 (21Aug)
Comment on attachment 8648461 [details] [review]
PR

Looks good to me, cheers
Attachment #8648461 - Flags: review?(dale) → review+
https://github.com/mozilla-b2g/b2g-installer/commit/5945f796edd69d9eee558947740c61085b360128
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.