crash in @0x0 | mozilla::layers::CompositingRenderTargetOGL::~CompositingRenderTargetOGL()

RESOLVED FIXED in Firefox 43

Status

()

Core
Graphics: Layers
--
critical
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: johnp, Assigned: acomminos)

Tracking

({crash})

Trunk
mozilla43
x86_64
Linux
crash
Points:
---

Firefox Tracking Flags

(firefox42 affected, firefox43 fixed)

Details

(crash signature)

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
This bug was filed from the Socorro interface and is 
report bp-00e63b79-d80b-4130-9c91-1963b2150816.
=============================================================

Crash with latest Fedora 22 KDE using pretty much all experimental layers features (APZ, acceleration forced, use-image-offscreen-surfaces). No STR.

Happened two times already. Here's the previous report (August 1st):

bp-3555e5a8-bbff-45b4-aafe-d7b452150801
(Reporter)

Updated

2 years ago
status-firefox42: --- → affected
Looks like something bad is happening in the destructor. We should be able to figure out what by looking at the disassembly.
Flags: needinfo?(acomminos)
(Assignee)

Comment 2

2 years ago
The only scenario I could find in the disassembly where we could jump to 0x0 would be if we're trying to call a symbol in a destroyed GLContext. The vtables of the participating classes seem sane.

We should modify the code here to check the result of GLContext::MakeCurrent before deleting the GL objects.
Flags: needinfo?(acomminos)
(Assignee)

Comment 3

2 years ago
Created attachment 8649487 [details] [diff] [review]
Check if GLContext is destroyed before freeing resources in CompositingRenderTargetOGL.
Attachment #8649487 - Flags: review?(jmuizelaar)
Attachment #8649487 - Flags: review?(jmuizelaar) → review+
(Assignee)

Updated

2 years ago
Assignee: nobody → acomminos
Status: NEW → ASSIGNED

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f9182aaadb1
https://hg.mozilla.org/mozilla-central/rev/6f9182aaadb1
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.