Closed Bug 1195142 Opened 4 years ago Closed 4 years ago

set CSS_PROPERTY_CREATES_STACKING_CONTEXT for the opacity property

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Keywords: css3)

Attachments

(2 files)

Per https://lists.w3.org/Archives/Public/www-style/2015Aug/0145.html we're missing the fact that will-change:opacity should force the creation of a stacking context.
Flags: needinfo?(bgirard)
It's actually not a bug because other code handles it.
Assignee: nobody → dbaron
Flags: needinfo?(bgirard)
Summary: will-change:opacity should force creation of a stacking context → set CSS_PROPERTY_CREATES_STACKING_CONTEXT for the opacity property
Bug 1195142 patch 1 - Set CSS_PROPERTY_CREATES_STACKING_CONTEXT for the opacity property.  r?BenWa

This isn't actually needed for the only caller (which ensures that
frames with will-change: opacity create a stacking context), since
nsIFrame::BuildDisplayListForChild checks HasOpacity, which checks for
NS_STYLE_WILL_CHANGE_OPACITY.  However, it's good to have the bit set
for consistency in case we use it elsewhere.
Attachment #8648579 - Flags: review?(bgirard)
Bug 1195142 patch 2 - Add reftests for will-change creating a stacking context.  r?BenWa
Attachment #8648580 - Flags: review?(bgirard)
Attachment #8648579 - Flags: review?(bgirard) → review+
Comment on attachment 8648579 [details]
MozReview Request: Bug 1195142 patch 1 - Set CSS_PROPERTY_CREATES_STACKING_CONTEXT for the opacity property.  r?BenWa

https://reviewboard.mozilla.org/r/16249/#review14517

Ship It!
Comment on attachment 8648580 [details]
MozReview Request: Bug 1195142 patch 2 - Add reftests for will-change creating a stacking context.  r?BenWa

https://reviewboard.mozilla.org/r/16251/#review14519

This is good. If we want better test coverage it would probably be useful to: 1) Test more properties that don't cause a stack context, 2) Have tests that have a list of will-change properties that mix and match permutations of properties a) that cause stacking context, b) that don't cause stacking context, c) that don't exist. ni? me if you'd like more to write these.
Attachment #8648580 - Flags: review?(bgirard)
Comment on attachment 8648580 [details]
MozReview Request: Bug 1195142 patch 2 - Add reftests for will-change creating a stacking context.  r?BenWa

https://reviewboard.mozilla.org/r/16251/#review14521

Ship It!
Attachment #8648580 - Flags: review+
You need to log in before you can comment on or make changes to this bug.