Closed
Bug 1195142
Opened 9 years ago
Closed 9 years ago
set CSS_PROPERTY_CREATES_STACKING_CONTEXT for the opacity property
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Keywords: css3)
Attachments
(2 files)
Per https://lists.w3.org/Archives/Public/www-style/2015Aug/0145.html we're missing the fact that will-change:opacity should force the creation of a stacking context.
Assignee | ||
Updated•9 years ago
|
Blocks: 964885, will-change
Keywords: css3
Assignee | ||
Comment 1•9 years ago
|
||
Looks like this got lost between bug 964885 comment 6 and bug 964885 comment 9.
Updated•9 years ago
|
Flags: needinfo?(bgirard)
Assignee | ||
Comment 2•9 years ago
|
||
It's actually not a bug because other code handles it.
Assignee: nobody → dbaron
Flags: needinfo?(bgirard)
Summary: will-change:opacity should force creation of a stacking context → set CSS_PROPERTY_CREATES_STACKING_CONTEXT for the opacity property
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=987219ca8e47
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1195142 patch 1 - Set CSS_PROPERTY_CREATES_STACKING_CONTEXT for the opacity property. r?BenWa This isn't actually needed for the only caller (which ensures that frames with will-change: opacity create a stacking context), since nsIFrame::BuildDisplayListForChild checks HasOpacity, which checks for NS_STYLE_WILL_CHANGE_OPACITY. However, it's good to have the bit set for consistency in case we use it elsewhere.
Attachment #8648579 -
Flags: review?(bgirard)
Assignee | ||
Comment 5•9 years ago
|
||
Bug 1195142 patch 2 - Add reftests for will-change creating a stacking context. r?BenWa
Attachment #8648580 -
Flags: review?(bgirard)
Updated•9 years ago
|
Attachment #8648579 -
Flags: review?(bgirard) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8648579 [details] MozReview Request: Bug 1195142 patch 1 - Set CSS_PROPERTY_CREATES_STACKING_CONTEXT for the opacity property. r?BenWa https://reviewboard.mozilla.org/r/16249/#review14517 Ship It!
Comment 7•9 years ago
|
||
Comment on attachment 8648580 [details] MozReview Request: Bug 1195142 patch 2 - Add reftests for will-change creating a stacking context. r?BenWa https://reviewboard.mozilla.org/r/16251/#review14519 This is good. If we want better test coverage it would probably be useful to: 1) Test more properties that don't cause a stack context, 2) Have tests that have a list of will-change properties that mix and match permutations of properties a) that cause stacking context, b) that don't cause stacking context, c) that don't exist. ni? me if you'd like more to write these.
Attachment #8648580 -
Flags: review?(bgirard)
Comment 8•9 years ago
|
||
Comment on attachment 8648580 [details] MozReview Request: Bug 1195142 patch 2 - Add reftests for will-change creating a stacking context. r?BenWa https://reviewboard.mozilla.org/r/16251/#review14521 Ship It!
Attachment #8648580 -
Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e3dbc9c729c https://hg.mozilla.org/integration/mozilla-inbound/rev/0a9680123c5f
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0e3dbc9c729c https://hg.mozilla.org/mozilla-central/rev/0a9680123c5f https://hg.mozilla.org/mozilla-central/rev/550b193f8f99
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•