Local move/copy failures should be done more gracefully

VERIFIED FIXED in mozilla0.9.9

Status

MailNews Core
Backend
P3
normal
VERIFIED FIXED
16 years ago
10 years ago

People

(Reporter: Navin Gupta, Assigned: Navin Gupta)

Tracking

Trunk
mozilla0.9.9

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
We should handle failed move/copy cases much better. We need to add
mDeleteOrMoveMsgFailed cases for local folders.

Updated

16 years ago
QA Contact: esther → sheelar
Summary: Local move/copy failures should be done more gracefully → Local move/copy failures should be done more gracefully
(Assignee)

Comment 1

16 years ago
Created attachment 64575 [details] [diff] [review]
proposed fix

The fix is to make sure that we truncate the msg and notify
mDeleteOrMoveMsgFailed in EndMove. I have added comments for explanation.
(Assignee)

Comment 2

16 years ago
cc bienvenu for review. 

I was working on a bug where delete was failing so decided to work on 
this. I have made sure that news, imap, local -> local are working 
and also local ->imap is working. Infact if local to imap move fails,
it works fine. 

Comment 3

16 years ago
Comment on attachment 64575 [details] [diff] [review]
proposed fix

looks ok, r=bienvenu, though of course, with this code, you just have to test
all the various permuations of copying single and multiple messages, things
like compact, etc.
Attachment #64575 - Flags: review+
(Assignee)

Comment 4

16 years ago
I will do more testing. I will check it in the next milestone. 
Status: NEW → ASSIGNED
OS: Windows NT → All
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → mozilla0.9.9
Does this to fix the condition described in bug 119493?

Comment 6

16 years ago
moving to 1.0.1
Target Milestone: mozilla0.9.9 → mozilla1.0.1
(Assignee)

Comment 7

16 years ago
moving to 0.9.9 so that I don't forget to check-in. very important, if 
delete fails, it freezes future move/copy/delete and also may not
show counts correctly.
Target Milestone: mozilla1.0.1 → mozilla0.9.9
(Assignee)

Comment 8

16 years ago
Infact it freezes up displaying msgs until we get out of the view by switching
folders/restarting. 

Comment 9

16 years ago
Comment on attachment 64575 [details] [diff] [review]
proposed fix

sr=mscott
Attachment #64575 - Flags: superreview+
(Assignee)

Comment 10

16 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 11

16 years ago
Tested single/multiple move from menu
imap to local
news to local
local to imap

verified using build 05-15-08 branch build on win98, linux, mac os x.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.