119515 - Local move/copy failures should be done more gracefully

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[Navin Gupta]

We should handle failed move/copy cases much better. We need to add
mDeleteOrMoveMsgFailed cases for local folders.

Comment 1

[Navin Gupta]

Attachment: proposed fix

The fix is to make sure that we truncate the msg and notify
mDeleteOrMoveMsgFailed in EndMove. I have added comments for explanation.

Comment 2

[Navin Gupta]

cc bienvenu for review. 

I was working on a bug where delete was failing so decided to work on 
this. I have made sure that news, imap, local -> local are working 
and also local ->imap is working. Infact if local to imap move fails,
it works fine. 

Comment 3

[David :Bienvenu]

Comment on attachment 64575 [details] [diff] [review]
proposed fix

looks ok, r=bienvenu, though of course, with this code, you just have to test
all the various permuations of copying single and multiple messages, things
like compact, etc.

Comment 4

[Navin Gupta]

I will do more testing. I will check it in the next milestone. 

Comment 5

[Quinn Yost (mythdraug)]

Does this to fix the condition described in bug 119493?

Comment 6

[scottputterman]

moving to 1.0.1

Comment 7

[Navin Gupta]

moving to 0.9.9 so that I don't forget to check-in. very important, if 
delete fails, it freezes future move/copy/delete and also may not
show counts correctly.

Comment 8

[Navin Gupta]

Infact it freezes up displaying msgs until we get out of the view by switching
folders/restarting. 

Comment 9

[Scott MacGregor]

Comment on attachment 64575 [details] [diff] [review]
proposed fix

sr=mscott

Comment 10

[Navin Gupta]

fixed

Comment 11

[Sheela Ravindran]

Tested single/multiple move from menu
imap to local
news to local
local to imap

verified using build 05-15-08 branch build on win98, linux, mac os x.