Closed Bug 1195159 Opened 10 years ago Closed 8 years ago

Retry on certain network errors

Categories

(Firefox :: Sync, defect, P3)

Product:
Firefox
Component:
Sync
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: markh, Unassigned)

Details

While testing Sync on a VM I saw the following error: > 1439777743942 Sync.Status DEBUG Status for engine bookmarks: error.engine.reason.unknown_fail > 1439777743948 Sync.Status DEBUG Status.service: success.status_ok => error.sync.failed_partial > 1439777743953 Sync.ErrorHandler DEBUG bookmarks failed: Error: NS_ERROR_NET_PARTIAL_TRANSFER (resource://services-sync/resource.js:419:19) JS Stack trace: waitForSyncCallback@async.js:104:9 < Res__request@resource.js:415:14 < Res__request@resource.js:397:14 < Res_get@resource.js:439:12 < SyncEngine.prototype._processIncoming@engines.js:1115:18 < BookmarksEngine.prototype._processIncoming@bookmarks.js:465:7 < SyncEngine.prototype._sync@engines.js:1546:7 < wrappedSync@bookmarks.js:230:11 < _sync@bookmarks.js:227:1 < WrappedNotify@util.js:148:21 < Engine.prototype.sync@engines.js:669:5 < _syncEngine@enginesync.js:199:7 < sync@enginesync.js:149:15 < onNotify@service.js:1306:7 < WrappedNotify@util.js:148:21 < WrappedLock@util.js:103:16 < _lockedSync@service.js:1295:12 < sync/<@service.js:1287:14 < WrappedCatch@util.js:77:16 < sync@service.js:1275:5 < Res__request@resource.js:397:14 < Res_get@resource.js:439:12 < SyncEngine.prototype._processIncoming@engines.js:1115:18 < BookmarksEngine.prototype._processIncoming@bookmarks.js:465:7 < SyncEngine.prototype._sync@engines.js:1546:7 < wrappedSync@bookmarks.js:230:11 < _sync@bookmarks.js:227:1 < WrappedNotify@util.js:148:21 < Engine.prototype.sync@engines.js:669:5 < _syncEngine@enginesync.js:199:7 < sync@enginesync.js:149:15 < onNotify@service.js:1306:7 < WrappedNotify@util.js:148:21 < WrappedLock@util.js:103:16 < _lockedSync@service.js:1295:12 < sync/<@service.js:1287:14 < WrappedCatch@util.js:77:16 < sync@service.js:1275:51439777744036 Sync.Engine.Addons DEBUG Refreshing reconciler state1439777744040 Sync.AddonsReconciler INFO Refreshing global state from Add This seems like a reasonable error to (somewhat) silently retry and only report an error state if the retry fails. Errors like "connection reset" etc also seem worth retrying.
I haven't seen errors like this for ages, it seems difficult to do sanely, and sync will end up retrying automatically anyway, so let's just drop this.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.