1195185 - Decouple the creation of mData from output stream addition for DecodedStream

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

See https://hg.mozilla.org/integration/mozilla-inbound/file/e44c94a159db/dom/media/DecodedStream.cpp#l268.

|mData| is created when the 1st output stream is connected. We should align its life cycle with {Start,Stop}Playback.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1195185. Part 1 - rename Connect/Remove to AddOutput/RemoveOutput.

Bug 1195185. Part 1 - rename Connect/Remove to AddOutput/RemoveOutput.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1195185. Part 2 - Check if all output streams are from the same graph because we don't support connecting streams from different graphs.

Bug 1195185. Part 2 - Check if all output streams are from the same graph because we don't support connecting streams from different graphs.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1195185. Part 3 - align the life cycle of mData with {Start,Stop}Playback.

Bug 1195185. Part 3 - align the life cycle of mData with {Start,Stop}Playback.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1195185. Part 4 - remove dead code.

Bug 1195185. Part 4 - remove dead code.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8649673 [details]
MozReview Request: Bug 1195185. Part 1 - rename Connect/Remove to AddOutput/RemoveOutput.

https://reviewboard.mozilla.org/r/16457/#review14837

Ship It!

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8649674 [details]
MozReview Request: Bug 1195185. Part 2 - Check if all output streams are from the same graph because we don't support connecting streams from different graphs.

https://reviewboard.mozilla.org/r/16459/#review14839

Ship It!

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8649675 [details]
MozReview Request: Bug 1195185. Part 3 - align the life cycle of mData with {Start,Stop}Playback.

https://reviewboard.mozilla.org/r/16461/#review14841

Ship It!

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8649676 [details]
MozReview Request: Bug 1195185. Part 4 - remove dead code.

https://reviewboard.mozilla.org/r/16463/#review14843

Ship It!

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c86b49946ff

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/940e2df934ce
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c51f1660e4a
https://hg.mozilla.org/integration/mozilla-inbound/rev/272e873bd425
https://hg.mozilla.org/integration/mozilla-inbound/rev/e96e3039b44b

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/940e2df934ce
https://hg.mozilla.org/mozilla-central/rev/9c51f1660e4a
https://hg.mozilla.org/mozilla-central/rev/272e873bd425
https://hg.mozilla.org/mozilla-central/rev/e96e3039b44b