Decouple the creation of mData from output stream addition for DecodedStream

RESOLVED FIXED in Firefox 43

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Assignee)

Description

3 years ago
See https://hg.mozilla.org/integration/mozilla-inbound/file/e44c94a159db/dom/media/DecodedStream.cpp#l268.

|mData| is created when the 1st output stream is connected. We should align its life cycle with {Start,Stop}Playback.
(Assignee)

Updated

3 years ago
Depends on: 1195187
(Assignee)

Updated

3 years ago
Blocks: 1195601
(Assignee)

Comment 1

3 years ago
Created attachment 8649673 [details]
MozReview Request: Bug 1195185. Part 1 - rename Connect/Remove to AddOutput/RemoveOutput.

Bug 1195185. Part 1 - rename Connect/Remove to AddOutput/RemoveOutput.
Attachment #8649673 - Flags: review?(roc)
(Assignee)

Comment 2

3 years ago
Created attachment 8649674 [details]
MozReview Request: Bug 1195185. Part 2 - Check if all output streams are from the same graph because we don't support connecting streams from different graphs.

Bug 1195185. Part 2 - Check if all output streams are from the same graph because we don't support connecting streams from different graphs.
Attachment #8649674 - Flags: review?(roc)
(Assignee)

Comment 3

3 years ago
Created attachment 8649675 [details]
MozReview Request: Bug 1195185. Part 3 - align the life cycle of mData with {Start,Stop}Playback.

Bug 1195185. Part 3 - align the life cycle of mData with {Start,Stop}Playback.
Attachment #8649675 - Flags: review?(roc)
(Assignee)

Comment 4

3 years ago
Created attachment 8649676 [details]
MozReview Request: Bug 1195185. Part 4 - remove dead code.

Bug 1195185. Part 4 - remove dead code.
Attachment #8649676 - Flags: review?(roc)
Comment on attachment 8649673 [details]
MozReview Request: Bug 1195185. Part 1 - rename Connect/Remove to AddOutput/RemoveOutput.

https://reviewboard.mozilla.org/r/16457/#review14837

Ship It!
Attachment #8649673 - Flags: review?(roc) → review+
Comment on attachment 8649674 [details]
MozReview Request: Bug 1195185. Part 2 - Check if all output streams are from the same graph because we don't support connecting streams from different graphs.

https://reviewboard.mozilla.org/r/16459/#review14839

Ship It!
Attachment #8649674 - Flags: review?(roc) → review+
Comment on attachment 8649675 [details]
MozReview Request: Bug 1195185. Part 3 - align the life cycle of mData with {Start,Stop}Playback.

https://reviewboard.mozilla.org/r/16461/#review14841

Ship It!
Attachment #8649675 - Flags: review?(roc) → review+
Comment on attachment 8649676 [details]
MozReview Request: Bug 1195185. Part 4 - remove dead code.

https://reviewboard.mozilla.org/r/16463/#review14843

Ship It!
Attachment #8649676 - Flags: review?(roc) → review+
(Assignee)

Comment 9

3 years ago
Thanks for the review!
(Assignee)

Updated

3 years ago
Assignee: nobody → jwwang
You need to log in before you can comment on or make changes to this bug.