119520 - Modern theme toolbar cleanup suggestions

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Simon Fraser [no longer active]]

The new modern theme introduced some subtle changes in the way the toolbars look
in relation to the native window border, and, on Mac, these give the chrome a
rather heavy, outlined look. I'll attach some screenshots that show how it looks
now, and what I think it should look like.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Screenshot of current toolbars, and cleaned up version

This attachment shows how our toolbars look now in modern (top), and how much
better they look when the borders are removed (PhotoShopped image, lower).

Comment 2

[Simon Fraser [no longer active]]

Attachment: Screenshots of scrollbars and lower toolbar improvements

Here I show some edited images that show how the scrollbar appearance could be
changed, and highlight the messy problem of positioning things around the
window's grow box. I've also added a dark 1-pixel border along the top of the
lower status bar, which I think is necessary to give a nice clean separation
between the content area and the lower toolbar.

Comment 3

[andreww]

Marlon is going to be redoing modern in many ways to allow it to be more 
modular. (for instance toolbars)
 CC'ing him for comments.

Comment 4

[marlon bishop]

Simon, that's how it was supposed to have been done in the first place. It would be great if you could make those changes happen.  cc'ing shliang 

Comment 5

[Simon Fraser [no longer active]]

Those are PhotoShopped images, not screenshots of changed XUL/CSS. So I don't 
have anything to check in  :)

Comment 6

[marlon bishop]

oh well :(

that border between window frame and toolbar is a regression, that's not in 6.2.1

Comment 7

[Joe Hewitt (gone)]

-> shliang

Comment 8

[Lori Kaplan]

accepting for shuehan during triage. nominating for 1.0. 

Comment 9

[shliang]

Attachment: patch

removing top and left borders of toolbox, and adding dark top border to
statusbar.

we can't remove the right border of the scrollbars because win doesn't have the
extra black border all the way around. the other extra borders also can't be
removed because the outermost border colors need to match up.

Comment 10

[Joe Hewitt (gone)]

Comment on attachment 71804 [details] [diff] [review]
patch

sr=hewitt

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 71804 [details] [diff] [review]
patch

r=sfraser

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 71804 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 13

[shliang]

fixed

Comment 14

[Patty Mac]

Verified on mac os 9.2 (commercial netscape build: 2002-03-19-03-trunk)