1195227 - [Flame KK][FM Radio]You can't hear the sound while the speaker mode is active.

Status: RESOLVED DUPLICATE of bug 1196724

(Firefox OS Graveyard :: Gaia::FMRadio, defect, P2)

Description

[Lance（leave from Mozilla）]

Attachment: logcat_1454.txt

[1.Description]:
[Flame KK v2.5][FM Radio]After launching FM, turn on speaker, then adjust the volume, the speaker volume can't be adjusted.
Found time:14:54
See attachment:FlameKK_2.5.3gp and logcat_1454.txt

[2.Testing Steps]: 
1.Launch FM.
2.Plug in headset.
3.Turn on the speaker icon.
4.Press volume key to adjust volume.

[3.Expected Result]: 
4.The volume should be adjusted.

[4.Actual Result]: 
4.The volume can't be adjusted.

[5.Reproduction build]: 
Device: Flame KK 2.2(Unaffected)
Build ID               20150816032505
Gaia Revision          335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gaia Date              2015-08-14 19:06:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-

b2g37_v2_2/rev/82ec88fa015c
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150816.070759
Firmware Date          Sun Aug 16 07:08:10 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5(Affected)
Build ID               20150816150205
Gaia Revision          47c91ffe7f500ca1aaa60de0aabf4d2429120733
Gaia Date              2015-08-14 18:55:02
Gecko Revision         https://hg.mozilla.org/mozilla-

central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150816.182145
Firmware Date          Sun Aug 16 18:21:56 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
11240

[8. Note]:
Because of the bug 1169778, i can't try this problem on Aries KK 2.5 device.

Comment 1

[Lance（leave from Mozilla）]

Attachment: FlameKK_2.5.3gp

Comment 2

[No-Jun Park [:njpark]]

[Blocking Requested - why for this release]:

I was able to repro this on the latest build on flame device When the speaker mode is enabled, the phone does not output any audio. Nominating it as a blocker

Comment 3

[Mahendra Potharaju [:mahe]]

P2, Blocks 2.5

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame
BuildID: 20150717080801
Gaia: 8c009877aff6b8b2f4a60756e2d09c0182393721
Gecko: 5e33f87ac681
Version: 42.0a1 (2.5 Master)
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

First Broken
Device: Flame
BuildID: 20150717080902
Gaia: 8c009877aff6b8b2f4a60756e2d09c0182393721
Gecko: c1bae5ba297f
Version: 42.0a1 (2.5 Master)
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Gaia is the same so it's a Gecko issue.

Gecko pushlog:
http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=5e33f87ac681&tochange=c1bae5ba297f

This issue is caused by either Bug 1170117 or Bug 1183301. We're unsure which one exactly could have caused it.

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Alastor this issue was caused by the changes for either bug 1170117 or bug 1183301.  Can you please take a look?

Comment 6

[Alastor Wu [:alwu]]

This issue is caused by that we don't change the speaker volume when we're in the "DEVICE_HEADSET" mode.
Although we turn on the speaker, the output profile doesn't change to the "DEVICE_PRIMARY".

---

Hi, Sotaro,
Could your patch, AudioManager refactoring, solve this issue?
Thanks!

Comment 7

[Sotaro Ikeda [:sotaro]]

patch of Bug 1196724 fixed the problem on master flame-kk.

Comment 8

[Alastor Wu [:alwu]]

According to the comment7, set duplication.

Comment 9

[Sotaro Ikeda [:sotaro]]

When I tested the STR in comment 0, I found one problem. During turning ON/OFF the speaker by touching speaker icon in FM radio app, short big sound was heard from speaker and headphone.

Comment 10

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #9)
> When I tested the STR in comment 0, I found one problem. During turning
> ON/OFF the speaker by touching speaker icon in FM radio app, short big sound
> was heard from speaker and headphone.

I observed it on b2g v2.2 and b2g b2.5.

Comment 11

[Alastor Wu [:alwu]]

In the flame?
The flame has DSP problem which would result the large distortion when we're switching the speaker and headset.
We have filed the bug, but I can't find the bug number now.

Comment 12

[Alastor Wu [:alwu]]

correct comment 11, it's BSP problem.
I remembered that the problem is because the wrong switching order of the audio codec and amplifier.
The amplifier is closed too late, so we can hear the noise which is generate by switching codec.

Comment 13

[Sotaro Ikeda [:sotaro]]

(In reply to Alastor Wu [:alwu] from comment #11)
> In the flame?

Yes, I confirmed it on flame-kk.

Comment 14

[Sotaro Ikeda [:sotaro]]

(In reply to Alastor Wu [:alwu] from comment #12)
> correct comment 11, it's BSP problem.
> I remembered that the problem is because the wrong switching order of the
> audio codec and amplifier.
> The amplifier is closed too late, so we can hear the noise which is generate
> by switching codec.

alwu, do you know whether the amplifier problem could be addressed by software?

Comment 15

[Alastor Wu [:alwu]]

I think this problem need partner's help.
Because what we can do in software is only to force speaker on or off, we don't touch the codec/amplifier.
How do you think?

Comment 16

[Sotaro Ikeda [:sotaro]]

From my experience, it seems better to find a fix by ourselves and ask for a confirmation of it to partners.

Do you know which code is related?

Comment 17

[Alastor Wu [:alwu]]

Hi, Sotaro,
Sorry, I don't know related code. 
Actually, I got this analysis from Randy (but Randy isn't in Mozilla now), so I didn't know detailed implementation or code about that.

Comment 18

[Sotaro Ikeda [:sotaro]]

Ok, thank. I am going to investigate about it when I have a time.