1195239 - [is][Desktop][Mobile] leit.is searchplugin is broken

Status: RESOLVED FIXED

(Mozilla Localizations :: is / Icelandic, defect)

Description

[Francesco Lodolo [:flod]]

http://hg.mozilla.org/releases/l10n/mozilla-aurora/is/file/ad6d9c5c4b0e/browser/searchplugins/leit-is.xml

http://leit.is/query.aspx is 404

The new URL should be something like
http://leit.is/leita?utf8=%E2%9C%93&search={searchterms}

Comment 1

[Francesco Lodolo [:flod]]

@Kristján
Is this searchplugin still relevant for Icelandic? In case we also need to update the icon for Fennec to 96px

Comment 2

[Kristján Bjarni Guðmundsson]

Yes I think we should still use this search engine for Icelandic. I can update the searchplugin but I only have available 78px icon for this website. Would that be okay?

Comment 3

[Francesco Lodolo [:flod]]

Attachment: leit.png

I found a 100px icon on the store, resized to 96px here.

I can take care of this bug, I'll need a tester to verify that everything works as expected though.

Comment 4

[Kristján Bjarni Guðmundsson]

Great. I should be able to test it and verify.

Comment 5

[Francesco Lodolo [:flod]]

Attachment: bug1195239.patch

This patch changes icons for both desktop (.ico with both 16px and 32px), and Android (96px).

Also switches search URL and encoding to UTF-8.

@Kristján
Can you test the two searchplugins at, in particular with utf-8 characters, and confirm if everything look good
https://l10n.mozilla-community.org/~flod/testsp/

I changed the actual names adding "- mobile" and "- desktop", so that you can test them even if you already have the default searchplugin installed.

Comment 6

[Kristján Bjarni Guðmundsson]

I tested the mobile leit.is search and it works correctly. I tested especially extended characters.
However I can't test the desktop version, since it conflicts with the already installed leit.is searchplugin.

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Kristján Bjarni Guðmundsson from comment #6)
> I tested the mobile leit.is search and it works correctly. I tested
> especially extended characters.
> However I can't test the desktop version, since it conflicts with the
> already installed leit.is searchplugin.

Apparently I changed the shortName locally but didn't upload the new version. Now fixed.

Anyhow, the structure is identical, so it should be safe to go in review. I tested both of them locally and the icons appear correctly.

Comment 8

[Kristján Bjarni Guðmundsson]

Ok tested the desktop version everything works correctly.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Kristján Bjarni Guðmundsson from comment #8)
> Ok tested the desktop version everything works correctly.

Thanks for checking!

Comment 10

[Francesco Lodolo [:flod]]

https://hg.mozilla.org/releases/l10n/mozilla-beta/is/rev/975c8aabbefa
https://hg.mozilla.org/releases/l10n/mozilla-aurora/is/rev/975c8aabbefa
https://hg.mozilla.org/l10n-central/is/rev/975c8aabbefa

Requested a new sign-off on Beta for both desktop and mobile.