Closed Bug 1195270 Opened 6 years ago Closed 6 years ago

[userstory] New visual design for the updated about:privatebrowsing page

Categories

(Firefox :: Private Browsing, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox43 --- affected

People

(Reporter: Paolo, Unassigned)

References

Details

(Whiteboard: [fxprivacy] [userstory])

This is the implementation bug for the design in bug 1192625.
Flags: qe-verify+
Depends on: 1193806
There's a quite interesting potential accessibility issue with this design and I couldn't find a good way to solve it, or a confirmation it is actually an issue.

In attachment 8647668 [details], look at the table layout in the left section:

Forget-header  Keep-header
Forget-list    Keep-list

The Forget-header and the Keep-header should have the same height so that the start of Forget-list and Keep-list are aligned. At the same time Keep-header and Keep-list must be aligned. The only way I found to do this was to use a table element, or a similar technique, for which the order of the cells in the source file would now be:

Forget-header
Keep-header
Forget-list
Keep-list

I'm not sure if screen readers would handle this correctly. The ideal reading order would be:

Forget-header
Forget-list
Keep-header
Keep-list

Tim, any idea whom we could ask?
Flags: needinfo?(ttaubert)
Blocks: 1188565
Flags: needinfo?(ttaubert) → needinfo?(bgrinstead)
(In reply to :Paolo Amadini from comment #1)
> There's a quite interesting potential accessibility issue with this design
> and I couldn't find a good way to solve it, or a confirmation it is actually
> an issue.
> 
> In attachment 8647668 [details], look at the table layout in the left
> section:
> 
> Forget-header  Keep-header
> Forget-list    Keep-list
> 
> The Forget-header and the Keep-header should have the same height so that
> the start of Forget-list and Keep-list are aligned. At the same time
> Keep-header and Keep-list must be aligned. The only way I found to do this
> was to use a table element, or a similar technique, for which the order of
> the cells in the source file would now be:
> 
> Forget-header
> Keep-header
> Forget-list
> Keep-list
> 
> I'm not sure if screen readers would handle this correctly. The ideal
> reading order would be:
> 
> Forget-header
> Forget-list
> Keep-header
> Keep-list

I've confirmed locally that NVDA reads these in the correct order.

Note: it's pretty easy to test screenreader support by downloading and running NVDA: http://www.nvaccess.org/download/.  Note that it's Windows only.
Flags: needinfo?(bgrinstead)
QA Contact: mwobensmith
Iteration: 43.1 - Aug 24 → 43.2 - Sep 7
Depends on: 1198286
Depends on: 1198287
No longer depends on: 1193806
Assignee: paolo.mozmail → nobody
No longer blocks: 1188565
Status: ASSIGNED → NEW
Iteration: 43.2 - Sep 7 → ---
Flags: qe-verify+
Priority: P1 → --
QA Contact: mwobensmith
Summary: New visual design for the updated about:privatebrowsing page → [userstory] New visual design for the updated about:privatebrowsing page
Whiteboard: [fxprivacy] → [fxprivacy] [userstory]
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1199168
Depends on: 1199644
Depends on: 1199650
Depends on: 1193806
You need to log in before you can comment on or make changes to this bug.