1195321 - 'Thumbnail removed' message overlaps search bar from newtab

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Screenshot showing the issue

Affected platforms: 
- Windows 7 64-bit
- Mac OS X 10.10.4
- Ubuntu 14.04 32-bit

Affected builds:
- latest Nightly 43.0a1
- latest Aurora 42.0a2

STR:
1. Open Firefox and navigate to about:newtab
2. Reduce the browsers width
2. Delete one thumbnail

Expected results: No visual issues can be seen.

Actual results: The undo menu overlaps Search bar from new tab

Comment 1

[Ed Lee :Mardak]

Probably made worse from bug 1180387 with it pushing the search bar upwards.

Comment 2

[maxim zhilyaev]

(In reply to Ed Lee :Mardak from comment #1)
> Probably made worse from bug 1180387 with it pushing the search bar upwards.

1180387 change was never uplifted to Aurora 42.0a2.
I verified that latest Aurora 42.0a2 build has the problem, and it does not have 1180387 changes.
Since 1180387 is not the root cause, 1180387 should depend on this regression. 
Hence, removing the dependency.

Comment 3

[maxim zhilyaev]

(In reply to maxim zhilyaev from comment #2)

> Since 1180387 is not the root cause, 1180387 should depend on this

This should read - "1180387 should NOT depend on this regression"

Comment 4

[Ed Lee :Mardak]

It was made worse by bug 1180387 because before that change, there usually was empty space for the undo message.

Comment 5

[maxim zhilyaev]

Attachment: Aurora 42.0a2 showing same problem wihtout 1180387 changes

Comment 6

[Ed Lee :Mardak]

When I said "it was made worse," I mean this bug is more likely to be seen by more users. Yes, even without the patch, it's possible to trigger the bug if the user's window is sized a certain way, but with the patch, the bug happens for a lot more window sizes.

Comment 7

[maxim zhilyaev]

Attachment: 1195321.patch.v1

Increasing top margin of the search-container to avoid overlaps with undo message.

Comment 8

[maxim zhilyaev]

Attachment: Undo message and search container with uncreased margin-top

Requesting info from aaron if this would be an acceptable fix.

Comment 9

[Ed Lee :Mardak]

Comment on attachment 8650202 [details] [diff] [review]
1195321.patch.v1

Approach is fine. Wait for dcrobot's spec on how far the search bar should be from the undo container as well as the customize/gear button.

Comment 10

[Aaron]

would it be possible to show this beneath the actual tile deleted, instead of in a fixed position upper/left?

Comment 11

[maxim zhilyaev]

(In reply to Aaron from comment #10)
> would it be possible to show this beneath the actual tile deleted, instead
> of in a fixed position upper/left?

It could be, but I would prefer to file that as a separate bug. I need to uplift all changes related to 1180387 (this bug included) to aurora/beta, preferably this Friday. I would  much prefer if we do a simple fix now.

Comment 12

[Aaron]

Max, I'm good with your solution. Don't worry about my comment above for now.

Thanks.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e7355d3ce8cc

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2ad682b0da99

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e7355d3ce8cc
https://hg.mozilla.org/mozilla-central/rev/2ad682b0da99

Comment 16

[Cornel Ionce [:noni] [Hubs QA]]

Confirming the fix on latest Nightly, build ID: 20150825030212.
Tested on Windows 7 64-bit, Windows 10 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 32-bit.

Filled bug 1198754, the cog wheel overlaps the thumbnail removal message when the window is resized.

Comment 17

[maxim zhilyaev]

Attachment: V1. 1195321 aurora patch

Approval Request Comment
[Feature/regressing bug #]:
A regression of 1180387
[User impact if declined]:
Significant - UX looks ugly
[Describe test coverage new/current, TreeHerder]:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab58a4b34f15
[Risks and why]: 
Low risk - the change is one-liner for css margin setting

[String/UUID change made/needed]: NONW

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8654659 [details] [diff] [review]
V1. 1195321 aurora patch

Bad UX, taking it.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/78ae41f10944

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Backed out for various newtab test failures.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5a9d52dfc064

https://treeherder.mozilla.org/logviewer.html#?job_id=1090951&repo=mozilla-aurora

Comment 21

[Ryan VanderMeulen [:RyanVM]]

The uplift of bug 1194895 actually fixed those failures before this backout landed. Re-landed.
https://hg.mozilla.org/releases/mozilla-aurora/rev/214492ce4267

Comment 22

[Cornel Ionce [:noni] [Hubs QA]]

Verified fixed on Windows 7 64-bit, Windows 10 32-bit, Mac OS X 10.9.5 and Ubuntu 12.04 32-bit using Firefox 42 beta 2, build ID: 20150928102225.