Closed Bug 1195337 Opened 5 years ago Closed 4 years ago

ReferenceError: smtp is not defined when opening Troubleshooting Information, causing whole page to have no data

Categories

(Thunderbird :: Mail Window Front End, defect, major)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 43.0

People

(Reporter: iann_bugzilla, Assigned: aceman)

References

Details

Attachments

(1 file)

4.14 KB, patch
mkmelin
: review+
iann_bugzilla
: feedback+
Details | Diff | Splinter Review
STR
1. Start TB
2. Click Help, Troubleshooting Information
3. Look in error console

Expected Result
1. Account information on troubleshooting page
2. No error in error console

Actual Result
1. Account information is empty on troubleshooting page
2. Following error in error console:
Timestamp: 17/08/15 15:55:26
Error: ReferenceError: smtp is not defined
Source File: chrome://messenger/content/about-support/accounts.js
Line: 75
I can see the error in the console. The whole troubleshooting page is now empty.
Assignee: nobody → acelists
Severity: normal → major
Status: NEW → ASSIGNED
Component: Untriaged → Mail Window Front End
Summary: ReferenceError: smtp is not defined when opening Troubleshooting Information → ReferenceError: smtp is not defined when opening Troubleshooting Information, causing whole page to have no data
Attached patch patchSplinter Review
I don't really know why, but this solves it for me. Maybe this form of nested loops/array member generators got broken/redesigned in m-c?
Attachment #8649336 - Flags: feedback?(iann_bugzilla)
Comment on attachment 8649336 [details] [diff] [review]
patch

Yes, it fixes it for me, but need to find out why it broke just in case there is other code that needs to be fixed too (and peace of mind too).
Attachment #8649336 - Flags: feedback?(iann_bugzilla) → feedback+
Jcranmer, do you know anything about these JS constructs?
Flags: needinfo?(Pidgeot18)
(In reply to :aceman from comment #4)
> Jcranmer, do you know anything about these JS constructs?

I can't answer these questions, you'd have to ask JS engine folk.
Flags: needinfo?(Pidgeot18)
Attachment #8649336 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8649336 [details] [diff] [review]
patch

Review of attachment 8649336 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know why it broke either, but your new code is more readable. r=mkmelin
Attachment #8649336 - Flags: review?(mkmelin+mozilla) → review+
Thanks, I think so too.
Keywords: checkin-needed
Aryx, can you please push this to try server so we see if it fixes all the about-support.js tests? Otherwise we'd need to file a new bug for the remaining parts. It looks like at least linux builds file.
Flags: needinfo?(aryx.bugmail)
Duplicate of this bug: 1200012
https://hg.mozilla.org/comm-central/rev/35d8f81ac1527a21d467be69cd293772a7a13c4e
Bug 1195337 - Fix undefined smtp variable by rewriting some array generators in about:troubleshooting. r=mkmelin a=bustage-fix on CLOSED TREE
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
Duplicate of this bug: 1201391
You need to log in before you can comment on or make changes to this bug.