1195337 - ReferenceError: smtp is not defined when opening Troubleshooting Information, causing whole page to have no data

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Ian Neal]

STR
1. Start TB
2. Click Help, Troubleshooting Information
3. Look in error console

Expected Result
1. Account information on troubleshooting page
2. No error in error console

Actual Result
1. Account information is empty on troubleshooting page
2. Following error in error console:
Timestamp: 17/08/15 15:55:26
Error: ReferenceError: smtp is not defined
Source File: chrome://messenger/content/about-support/accounts.js
Line: 75

Comment 1

[:aceman]

I can see the error in the console. The whole troubleshooting page is now empty.

Comment 2

[:aceman]

Attachment: patch

I don't really know why, but this solves it for me. Maybe this form of nested loops/array member generators got broken/redesigned in m-c?

Comment 3

[Ian Neal]

Comment on attachment 8649336 [details] [diff] [review]
patch

Yes, it fixes it for me, but need to find out why it broke just in case there is other code that needs to be fixed too (and peace of mind too).

Comment 4

[:aceman]

Jcranmer, do you know anything about these JS constructs?

Comment 5

[Joshua Cranmer [:jcranmer]]

(In reply to :aceman from comment #4)
> Jcranmer, do you know anything about these JS constructs?

I can't answer these questions, you'd have to ask JS engine folk.

Comment 6

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=22862
repository: comm-central
start_time: 2015-08-24T07:10:25
who: acelists[at]atlas[dot]sk
machine: tst-linux32-spot-456
buildname: Ubuntu VM 12.04 comm-central opt test mozmill
revision: 95e56121a3ff

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-policy/test-general-content-policy.js | test-general-content-policy.js::test_generalContentPolicy
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_display_about_support
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_accounts_in_order
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_modified_pref_on_whitelist
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_modified_pref_not_on_whitelist
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_modified_pref_on_blacklist
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_private_data
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_copy_to_clipboard_public
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_copy_to_clipboard_private
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_send_via_email_public
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_send_via_email_private
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
Return code: 1
No tests run or test summary not found

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=22860
repository: comm-central
start_time: 2015-08-24T07:10:29
who: acelists[at]atlas[dot]sk
machine: tst-linux64-spot-1791
buildname: Ubuntu VM 12.04 x64 comm-central debug test mozmill
revision: 95e56121a3ff

OSError: [Errno 2] No such file or directory
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-policy/test-general-content-policy.js | test-general-content-policy.js::test_generalContentPolicy
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_display_about_support
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_accounts_in_order
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_modified_pref_on_whitelist
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_modified_pref_not_on_whitelist
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_modified_pref_on_blacklist
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_private_data
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_copy_to_clipboard_public
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_copy_to_clipboard_private
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_send_via_email_public
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_send_via_email_private
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
Return code: 1
No tests run or test summary not found

Comment 8

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=22856
repository: comm-central
start_time: 2015-08-24T07:01:10
who: acelists[at]atlas[dot]sk
machine: tst-linux64-spot-1820
buildname: Ubuntu VM 12.04 x64 comm-central opt test mozmill
revision: 95e56121a3ff

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-policy/test-general-content-policy.js | test-general-content-policy.js::test_generalContentPolicy
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_display_about_support
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_accounts_in_order
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_modified_pref_on_whitelist
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_modified_pref_not_on_whitelist
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_modified_pref_on_blacklist
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_private_data
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_copy_to_clipboard_public
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_copy_to_clipboard_private
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_send_via_email_public
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/content-tabs/test-about-support.js | test-about-support.js::test_send_via_email_private
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
Return code: 1
No tests run or test summary not found

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 8649336 [details] [diff] [review]
patch

Review of attachment 8649336 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know why it broke either, but your new code is more readable. r=mkmelin

Comment 10

[:aceman]

Thanks, I think so too.

Comment 11

[:aceman]

Aryx, can you please push this to try server so we see if it fixes all the about-support.js tests? Otherwise we'd need to file a new bug for the remaining parts. It looks like at least linux builds file.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Pushed as https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9af8c4ba07d1

Comment 14

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/35d8f81ac1527a21d467be69cd293772a7a13c4e
Bug 1195337 - Fix undefined smtp variable by rewriting some array generators in about:troubleshooting. r=mkmelin a=bustage-fix on CLOSED TREE