1195340 - Migrate the siteIcon to the new gaia-app-icon component

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

Migrate the icon displayed in the app_chrome to the new gaia component:

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/bower_components/gaia-app-icon

Move the component to the shared gaia-components repo (https://github.com/gaia-components)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1195340-migrate-icon-component > mozilla-b2g:master

Comment 2

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/gaia-components/gaia-site-icon/pull/2

Changes to the gaia-site-icon (renamed from gaia-app-icon) needed to land the patch to master

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8649379 [details]
Link to Pull Request: https://github.com/gaia-components/gaia-site-icon/pull/2

I've left a comment on github - not quite ready to r+ yet, I think this needs to wait for marionette tests (bug 1191746) to land so it can be rebased on any fixes made for that. That way we can move the homescreen over immediately after and make sure it has good test coverage.

Comment 4

[Alberto Pastor [:albertopq]]

Note that the homescreen still points to your gitlab version, so it shouldn't affect on anything, but I agree that it makes more sense to wait until the component is finalized before migrating the site icon to it. Thanks!

Comment 5

[Alberto Pastor [:albertopq]]

Not working on it at the moment..

Comment 6

[BMO Automation]

Firefox OS is not being worked on