1195349 - make css-color.js preserve case

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Tom Tromey :tromey]

While working on the as-authored project, I noticed that
css-color.js might not preserve the case of the input text.
I think it should.

Comment 1

[Tom Tromey :tromey]

Attachment: make css-color preserve original text; add classifyColor

This patch also adds classifyColor, which is used subsequently in the
as-authored series.

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8648758 [details] [diff] [review]
make css-color preserve original text; add classifyColor

Review of attachment 8648758 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: toolkit/devtools/css-color.js
@@ +259,5 @@
>     * @param  {String} color
>     *         Any valid color string
>     */
>    newColor: function(color) {
> +    this.lowerCased = color.toLowerCase();

This requires a short comment I think. Maybe:

// Store the lowerCased version of this color to help with color format testing later. The actual authored text is also kept so it can be returned when needed.

Comment 3

[Tom Tromey :tromey]

Attachment: make css-color preserve original text; add classifyColor

Updated per review.

Comment 4

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8369184e9de

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1d2f59732f03

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out for test_cssColor.js failures.
https://treeherder.mozilla.org/logviewer.html#?job_id=4451974&repo=fx-team

https://hg.mozilla.org/integration/fx-team/rev/810257543b7c

Comment 7

[Tom Tromey :tromey]

Attachment: Make css-color preserve original text; add classifyColor.

Don't redefine "loader" in the test.

Comment 8

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c02daee1dbaf

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/326daa2650c3

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/326daa2650c3