Closed
Bug 1195357
Opened 9 years ago
Closed 9 years ago
make TextProperty.stringifyProperty correctly escape comments
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
Attachments
(1 file, 1 obsolete file)
5.60 KB,
patch
|
tromey
:
review+
|
Details | Diff | Splinter Review |
While working on bug 984880, I noticed that TextProperty.stringifyProperty will do the wrong thing when stringifying a disabled property that appears to include a comment end. This can happen in a situation like: div { --var: "*/"; }
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8648769 -
Flags: review?(pbrosset)
Updated•9 years ago
|
Attachment #8648769 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Updated for the devtools renaming.
Attachment #8648769 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8666786 -
Flags: review+
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=894796ed44a5
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a22bad103d69
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•