1195472 - ASSERTION: does it make sense to Show()/Hide() a disabled widget?: 'mEnabled', file PuppetWidget.cpp, line 183 in layout/generic/crashtests/505912-1.html when run in e10s mode

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

crashtest-e10s was enabled on Linux today and this assertion was hitting on a permafail basis. I'm filing it for now, but it would be cool if you could look into it, Aaron. It's 100% reproducible on our infra.

https://treeherder.mozilla.org/logviewer.html#?job_id=12948833&repo=mozilla-inbound

11:55:38 INFO - REFTEST TEST-END | file:///builds/slave/test/build/tests/reftest/tests/layout/generic/crashtests/508908-1.html
11:55:38 INFO - REFTEST TEST-START | file:///builds/slave/test/build/tests/reftest/tests/layout/generic/crashtests/505912-1.html
11:55:38 INFO - REFTEST TEST-LOAD | file:///builds/slave/test/build/tests/reftest/tests/layout/generic/crashtests/505912-1.html | 1879 / 2855 (65%)
11:55:38 INFO - ++DOMWINDOW == 79 (0x7f072b928800) [pid = 1898] [serial = 4371] [outer = 0x7f0758e8a400]
11:55:38 INFO - For application/x-test found plugin libnptest.so
11:55:38 INFO - [Child 1898] ###!!! ASSERTION: does it make sense to Show()/Hide() a disabled widget?: 'mEnabled', file /builds/slave/m-in-l64-d-0000000000000000000/build/src/widget/PuppetWidget.cpp, line 183
11:55:38 INFO - #01: nsPluginFrame::PrepForDrawing(nsIWidget*) [layout/generic/nsPluginFrame.cpp:310]
11:55:38 INFO - #02: nsPluginInstanceOwner::CreateWidget() [dom/plugins/base/nsPluginInstanceOwner.cpp:2991]
11:55:38 INFO - #03: nsPluginHost::CreateWidget(nsPluginInstanceOwner*) [dom/plugins/base/nsPluginHost.cpp:3643]
11:55:38 INFO - #04: nsPluginHost::InstantiatePluginInstance(nsACString_internal const&, nsIURI*, nsObjectLoadingContent*, nsPluginInstanceOwner**) [dom/plugins/base/nsPluginHost.cpp:868]
11:55:38 INFO - #05: nsObjectLoadingContent::InstantiatePluginInstance(bool) [xpcom/glue/nsCOMPtr.h:721]
11:55:38 INFO - #06: nsObjectLoadingContent::SyncStartPluginInstance() [dom/base/nsObjectLoadingContent.cpp:2874]
11:55:38 INFO - #07: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:864]
11:55:38 INFO - #08: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/glue/nsThreadUtils.cpp:277]
11:55:38 INFO - #09: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:96]
11:55:38 INFO - #10: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:235]
11:55:38 INFO - #11: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:520]
11:55:38 INFO - #12: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:158]
11:55:38 INFO - #13: XRE_RunAppShell [toolkit/xre/nsEmbedFunctions.cpp:785]
11:55:38 INFO - #14: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:259]
11:55:38 INFO - #15: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:235]
11:55:38 INFO - #16: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:520]
11:55:38 INFO - #17: XRE_InitChildProcess [toolkit/xre/nsEmbedFunctions.cpp:625]
11:55:38 INFO - #18: content_process_main(int, char**) [ipc/contentproc/plugin-container.cpp:240]
11:55:38 INFO - #19: libc.so.6 + 0x2176d
11:55:38 INFO - #20: _start
11:55:38 INFO - REFTEST TEST-PASS | file:///builds/slave/test/build/tests/reftest/tests/layout/generic/crashtests/505912-1.html | (LOAD ONLY)
11:55:38 INFO - REFTEST INFO | Loading a blank page
11:55:38 INFO - ++DOMWINDOW == 80 (0x7f072b92ac00) [pid = 1898] [serial = 4372] [outer = 0x7f0758e8a400]
11:55:39 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/generic/crashtests/505912-1.html | assertion count 1 is more than expected 0 assertions
11:55:39 INFO - REFTEST TEST-END | file:///builds/slave/test/build/tests/reftest/tests/layout/generic/crashtests/505912-1.html

Comment 1

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/b3be345ec4d3

Comment 2

[Jim Mathies [:jimm]]

The order here was set way back in 2012 through some updates by josh - 

http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsPluginFrame.cpp#308

Lets just reverse those calls.

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8649303 [details] [diff] [review]
patch

Review of attachment 8649303 [details] [diff] [review]:
-----------------------------------------------------------------

s/runnign/running in commit description

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Presumably we'll need to remove the assertion annotation from the manifest as well?

Comment 6

[Jim Mathies [:jimm]]

Attachment: patch

Comment 7

[Jim Mathies [:jimm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=301f3282c421

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c9e0832c577d

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c9e0832c577d