1195486 - Convert nsConsoleService member-variable "mMessages" to use smart pointers for safety

Status: NEW

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

nsConsoleService has a member-variable...
  nsIConsoleMessage** mMessages;
...whose members we NS_ADDREF and NS_RELEASE manually as we modify the array:
http://mxr.mozilla.org/mozilla-central/search?string=NS_ADDREF&find=nsConsoleService
http://mxr.mozilla.org/mozilla-central/search?string=NS_RELEASE&find=nsConsoleService


We should use smart pointers here instead, to manage the refcount for us and avoid accidental mis-addref'ing. (This member-variable should really have type nsCOMArray<nsIConsoleMessage>, or nsTArray<nsCOMPtr<nsIConsoleMessage>>.)