Closing dialog does not show in current builds

VERIFIED FIXED in mozilla0.9.9

Status

Core Graveyard
QuickLaunch (AKA turbo mode)
VERIFIED FIXED
16 years ago
5 years ago

People

(Reporter: Grace Bush, Assigned: Dan M)

Tracking

Trunk
mozilla0.9.9
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
St
(Reporter)

Comment 1

16 years ago
Steps to reproduce:

install build 20020011103
leave turbo check on 
launch with migrated profile
file/quit

expected result:  dialog telling user about QuickLaunch (with box to check to
NOT be alerted in future)

actual results:  no dialog on this launch or any subsequent launch

Comment 2

16 years ago
This is due to some change in xul window close logic.  Reassigning to danm.

Dan, this has caught up to us already.
Assignee: law → danm
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
(Assignee)

Comment 3

16 years ago
Created attachment 66363 [details] [diff] [review]
allow this new window during window teardown

This patch moves up nsAppShellService's involvement in the window destruction
process to the point before the flag disallowing the creation of new windows is
set.

Comment 4

16 years ago
Comment on attachment 66363 [details] [diff] [review]
allow this new window during window teardown

r=law

Thanks, Dan.  QuickLaunch users will be happy.
Attachment #66363 - Flags: review+
(Assignee)

Comment 5

16 years ago
.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

16 years ago
got it on both Win98 and WinNT installations!  
(build 2002012506)
Status: RESOLVED → VERIFIED
(Reporter)

Comment 7

16 years ago
this is showing up again today on build 2002020406 on WinNT only 
testing on 98 and 2k shows the message
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

16 years ago
Please retest. This is still working on my win2k machine, and the patch that
fixed this shouldn't be fragile or subject to platform peculiarities.
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

16 years ago
verified on NT,98 and 2k build 2002022003
Status: RESOLVED → VERIFIED
Component: QuickLaunch (AKA turbo mode) → QuickLaunch (AKA turbo mode)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.