1195572 - Enable -Wformat-security in DOM::Security

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[François Marier [:francois]]

All of the code under dom/security currently builds fine with it both on gcc and clang.

Comment 1

[François Marier [:francois]]

Attachment: MozReview Request: Bug 1195572 - Enable -Wformat-security in DOM::Security. r?ckerschb

Bug 1195572 - Enable -Wformat-security in DOM::Security. r?ckerschb

Comment 2

[Christoph Kerschbaumer [:ckerschb}]

Comment on attachment 8649025 [details]
MozReview Request: Bug 1195572 - Enable -Wformat-security in DOM::Security. r?ckerschb

https://reviewboard.mozilla.org/r/16347/#review14613

::: dom/security/moz.build:46
(Diff revision 1)
> -    CXXFLAGS += ['-Wshadow']
> +    CXXFLAGS += ['-Wshadow', '-Wformat-security']

Thanks for looking into this. Good to know that everything builds just fine - we should keep it that way!

Comment 3

[François Marier [:francois]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28137489173e

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b1fccda7a74

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4b1fccda7a74