Closed Bug 1195580 Opened 10 years ago Closed 11 months ago

Unexpected error during validation

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: m_khvoinitsky, Unassigned)

Details

Attachments

(1 file)

* Error occures during validation while submitting a new version of an existing add-on. * add-on is listed. * https://addons.mozilla.org/en-US/developers/addon/black-background-white-text/versions#version-upload * 2015.08.18 ~00.00 UTC
Kris, any idea? I can't reproduce the failure locally (but can reproduce it on the standalone validator on production)
Flags: needinfo?(kmaglione+bmo)
It seems to be because of the `new` keyword before `require()`. I'd suggest fixing your code so that it doesn't try to use `require` as a constructor. This will be fixed by the PR I'm currently working on, but won't be live for at least a couple of weeks. Traceback (most recent call last): File "/home/kris/code/amo-validator-other/validator/testcases/javascript/traverser.py", line 78, in run self._traverse_node(data) File "/home/kris/code/amo-validator-other/validator/testcases/javascript/traverser.py", line 192, in _traverse_node map(self._traverse_node, b) File "/home/kris/code/amo-validator-other/validator/testcases/javascript/traverser.py", line 168, in _traverse_node action_result = action(self, node) File "/home/kris/code/amo-validator-other/validator/testcases/javascript/actions.py", line 311, in _define_var var_value = traverser._traverse_node(declaration['init']) File "/home/kris/code/amo-validator-other/validator/testcases/javascript/traverser.py", line 168, in _traverse_node action_result = action(self, node) File "/home/kris/code/amo-validator-other/validator/testcases/javascript/actions.py", line 355, in _define_obj var_value = traverser._traverse_node(prop['value']) File "/home/kris/code/amo-validator-other/validator/testcases/javascript/traverser.py", line 168, in _traverse_node action_result = action(self, node) File "/home/kris/code/amo-validator-other/validator/testcases/javascript/actions.py", line 355, in _define_obj var_value = traverser._traverse_node(prop['value']) File "/home/kris/code/amo-validator-other/validator/testcases/javascript/traverser.py", line 168, in _traverse_node action_result = action(self, node) File "/home/kris/code/amo-validator-other/validator/testcases/javascript/actions.py", line 444, in _call_expression e=traverser.err) File "/home/kris/code/amo-validator-other/validator/testcases/javascript/actions.py", line 527, in _call_require module = traverse(args[0]).get_literal_value() IndexError: list index out of range
Assignee: nobody → kmaglione+bmo
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(kmaglione+bmo)
Product: addons.mozilla.org → addons.mozilla.org Graveyard
Assignee: kmaglione+bmo → nobody
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: