1195601 - Remove MediaDecoderStateMachine::mLogicallySeeking

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

It is a workaround introduced by bug 1158448. See bug 1158448 comment 26.

The workaround exists because the life cycle of DecodedStream::mData is not aligned with {Start,Stop}Playback which makes it possible for SendData() to send data to the wrong stream which is about to be destroyed.

Since bug 1195185 fixes the life cycle of DecodedStream::mData, we are able to remove this workaround now.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=04d6f629a482

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6624d13b158

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

This bug also slightly improves the performance of MDSM which can start decoding immediately right after seek completed is observed from the state machine thread without waiting to be notified when seek completed observed from the main thread.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1195601 - Remove MediaDecoderStateMachine::mLogicallySeeking. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/49121/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49121/

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8745857 [details]
MozReview Request: Bug 1195601 - Remove MediaDecoderStateMachine::mLogicallySeeking. r=kinetik.

https://reviewboard.mozilla.org/r/49121/#review45947

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/632859a8e325

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/632859a8e325