Closed Bug 1195601 Opened 5 years ago Closed 4 years ago

Remove MediaDecoderStateMachine::mLogicallySeeking

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

It is a workaround introduced by bug 1158448. See bug 1158448 comment 26.

The workaround exists because the life cycle of DecodedStream::mData is not aligned with {Start,Stop}Playback which makes it possible for SendData() to send data to the wrong stream which is about to be destroyed.

Since bug 1195185 fixes the life cycle of DecodedStream::mData, we are able to remove this workaround now.
Depends on: 1195185, 1158448
Priority: -- → P2
This bug also slightly improves the performance of MDSM which can start decoding immediately right after seek completed is observed from the state machine thread without waiting to be notified when seek completed observed from the main thread.
Comment on attachment 8745857 [details]
MozReview Request: Bug 1195601 - Remove MediaDecoderStateMachine::mLogicallySeeking. r=kinetik.

https://reviewboard.mozilla.org/r/49121/#review45947
Attachment #8745857 - Flags: review?(kinetik) → review+
Thanks!
https://hg.mozilla.org/mozilla-central/rev/632859a8e325
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.