1195657 - [Stingray][Home] Should focus on the leftmost card when initialize

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Home app should focus on the leftmost card rather than search button on its first initialization.

Comment 1

[Mike Hoye [:mhoye]]

Can you give me a source link for where this change would live?

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1195657-focus-leftmost-card > mozilla-b2g:master

Comment 3

[Fischer [:Fischer]]

Attachment: Focus on the leftmost card on initial

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8653927 [details] [review]
Focus on the leftmost card on initial

r+ with a comment on Github.

Please make related changes and rebase before landing.

Comment 5

[Fischer [:Fischer]]

Commit: https://github.com/mozilla-b2g/gaia/commit/22694da9985b33e11cd4165a4078dda96fc82213

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Backout since it breaks GijTV.
https://github.com/mozilla-b2g/gaia/commit/c4a914c74bedb6b98621103bb75966d05eb48151

Please fix the integration test and send pull request again.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1195657-focus-leftmost-card > mozilla-b2g:master

Comment 8

[Fischer [:Fischer]]

Attachment: Fix focusing on the leftmost card

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8654785 [details] [review]
Fix focusing on the leftmost card

Looks good to me. I'm not sure if we need to wait both card and button. You can leave just tv button if possible.

Comment 10

[Fischer [:Fischer]]

commit: https://github.com/mozilla-b2g/gaia/commit/6918dbdebed34bcb2ef8cce0f1a2076178d5e36e

Comment 11

[Cynthia Tang [:cynthiatang]]

The highlight should focus on the initial card. Thank you.

Comment 12

[Fischer [:Fischer]]

Please focus on the b2g emulator as soon as on launch then the initial card would get highlighted