Closed Bug 1195657 Opened 5 years ago Closed 5 years ago

[Stingray][Home] Should focus on the leftmost card when initialize

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rexboy, Assigned: Fischer)

References

Details

(Whiteboard: [ft:conndevices][good-first-bug])

Attachments

(4 files)

Home app should focus on the leftmost card rather than search button on its first initialization.
Can you give me a source link for where this change would live?
Depends on: 1198099
Assignee: nobody → fliu
Attachment #8653927 - Flags: review?(rexboy)
Comment on attachment 8653927 [details] [review]
Focus on the leftmost card on initial

r+ with a comment on Github.

Please make related changes and rebase before landing.
Attachment #8653927 - Flags: review?(rexboy) → review+
Commit: https://github.com/mozilla-b2g/gaia/commit/22694da9985b33e11cd4165a4078dda96fc82213
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Backout since it breaks GijTV.
https://github.com/mozilla-b2g/gaia/commit/c4a914c74bedb6b98621103bb75966d05eb48151

Please fix the integration test and send pull request again.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8654785 - Flags: review?(rexboy)
Comment on attachment 8654785 [details] [review]
Fix focusing on the leftmost card

Looks good to me. I'm not sure if we need to wait both card and button. You can leave just tv button if possible.
Attachment #8654785 - Flags: review?(rexboy) → review+
commit: https://github.com/mozilla-b2g/gaia/commit/6918dbdebed34bcb2ef8cce0f1a2076178d5e36e
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
The highlight should focus on the initial card. Thank you.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Please focus on the b2g emulator as soon as on launch then the initial card would get highlighted
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.