1195702 - Expose UDPSocket existence in navigator.hasFeature()

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: General, defect, P1)

Description

[Mathieu Pillard [:mat]]

In bug 745283 UDPSocket was implemented and it's available to privileged apps [0].

Marketplace needs to separate devices with and without access to UDPSocket implementation, without requiring the permission itself. navigator.hasFeature() [1] is supposed to be used for that, but navigator.hasFeature('api.window.Navigator.UDPSocket') appears to be unimplemented.

Could it be implemented for all versions of gecko that are shipping with that API ? I'm hesitant to allow apps using this API to be submitted to Marketplace without the ability for Marketplace to detect if the API works or not, since that means users on older versions would be able to see and install apps that are broken to them.

[0] https://mxr.mozilla.org/mozilla-central/source/dom/apps/PermissionsTable.jsm#67
[1] https://dxr.mozilla.org/mozilla-central/source/dom/base/Navigator.cpp#1510

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: hasfeature-udpsocket.patch

Comment 2

[(no longer active)]

Comment on attachment 8678390 [details] [diff] [review]
hasfeature-udpsocket.patch

Review of attachment 8678390 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/Navigator.cpp
@@ +1695,5 @@
>        p->MaybeResolve(true);
>        return p.forget();
>      }
>  
> +    if (featureName.EqualsLiteral("Navigator.UDPSocket")) {

This shouldn't be needed, see bug 1009645.

Comment 3

[[:fabrice] Fabrice Desré]

Mat, which versions did you test?

Comment 4

[David Durst [:ddurst]]

Ehhhh. We tested a few months ago on this. Looking at the isFeatureDetectible() code, it's entirely possible we didn't have the check correct.

We'll double-check. I have a 2.1 and 2.5 handy that I can check now.

Comment 5

[Mathieu Pillard [:mat]]

Indeed it's already working on 2.5 ; I just had the wrong string, because I was expecting it to be similar to TCPSocket :(

<<< navigator.hasFeature('api.window.UDPSocket').then(function(val) { console.log(val); });
>>> true