1195704 - Accept and add feature flag for udp-socket permission / UDPSocket API

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect, P3)

Description

[Mathieu Pillard [:mat]]

Marketplace does not know about UDPSocket with was implemented in bug 745283. We need to:
- Add the permission in the validator for privileged apps
- Add the API detection bits to validator (detect "UDPSocket")
- Make a feature flag (depends on bug 1195702) to detect usage of this API and hide apps using this API from incompatible devices running older versions of FxOS.

Comment 1

[David Durst [:ddurst]]

If this is not going to be exposed via hasFeature, I'm not thrilled about hacking around this for 2.1, which is supposed to go out in just a few weeks.

NI Fabrice for the hasFeature aspect, which is covered in bug 1195702, but more relevant to the priority setting of this (and a new marketplace package uplift) bug.

Comment 2

[[:fabrice] Fabrice Desré]

Implementing the hasFeature() part is easy. If you guys feel strongly about that I can expedite it, but I'm not sure that partners will ship it (eg. I know some partners are doing their final image builds for 2.1s right now and will not take a new patch).

Comment 3

[David Durst [:ddurst]]

If it's easy, let's do it.

Comment 4

[André Fiedler]

Any news about that?

Comment 5

[Mathieu Pillard [:mat]]

It depends on bug 1195702, which is still opened and unassigned. Fabrice, could you implement the hasFeature() flag there for 2.2+ ? (I'm ignoring 2.1, we missed that train)

Comment 6

[[:fabrice] Fabrice Desré]

See patch in bug 1195702

Comment 7

[Mathieu Pillard [:mat]]

Fixed in:
- https://github.com/mozilla/fireplace/commit/030279d6f350380ad7f2822b0da72b52a9b702eb
- https://github.com/mozilla/app-validator/commit/60e17bccb1b00f45c235fb0036663c349453afa2
- https://github.com/mozilla/zamboni/commit/bc36444ef8efe62e7c27b8f540537b5586ba5794 and https://github.com/mozilla/zamboni/commit/b13a8f61d44497195c2a006623810d3d60d8f683

STR:
Devhub side:
- Check that a new feature requirement checkbox "udp sockets" is available in devhub
- Check that this checkbox is automatically checked when submitting a packaged app using "UDPSocket" in its javascript code

Frontend side:
- Update Marketplace dev package (version should be 20151028.191724)
- Check that with Firefox OS 2.1+, apps using udp socket feature requirement are shown. In debug page -> feature profile information, udp socket should be present (green).
- Check that with Firefox OS 2.0, 1.3, etc apps using udp socket feature requirement are not shown. In debug page -> feature profile information, udp socket should be absent (red).