[Settings] remove screenlock panel strings in HTML

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gasolin@mozilla.com, Assigned: danhuang, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: good-first-bug, zh)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
according to l10n guide, we could remove strings in HTML tags.

Comment 1

3 years ago
Can I get a source URL for this fix?
(Reporter)

Comment 2

3 years ago
This issue is bound to screen_lock & screen_lock_passcode.html
https://github.com/mozilla-b2g/gaia/tree/master/apps/settings/elements

Feel free to create new bug and remove strings in relative panels.

FYR: l10n best practices
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices
(Assignee)

Updated

3 years ago
Assignee: nobody → dhuang
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
Created attachment 8650838 [details] [review]
[gaia] danhuang1202:1195709_remove_screenlock_panel_string > mozilla-b2g:master
(Assignee)

Comment 4

3 years ago
Comment on attachment 8650838 [details] [review]
[gaia] danhuang1202:1195709_remove_screenlock_panel_string > mozilla-b2g:master

Please help to review. I had removed tag string with i10n attr in screen_lock.html and screen_lock_passcode.html. Thanks.
Attachment #8650838 - Flags: review?(gasolin)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8650838 [details] [review]
[gaia] danhuang1202:1195709_remove_screenlock_panel_string > mozilla-b2g:master

Thanks! Now you can merge the commit.
Attachment #8650838 - Flags: review?(gasolin) → review+
(Assignee)

Comment 6

3 years ago
Thanks for the review.
Keywords: checkin-needed
(Reporter)

Comment 7

3 years ago
merged https://github.com/mozilla-b2g/gaia/commit/f6cde6b8a2af2d2cfa3ce9b7f4cda2daab9174a8

congrats for first gaia commit!
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.