1195709 - [Settings] remove screenlock panel strings in HTML

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

according to l10n guide, we could remove strings in HTML tags.

Comment 1

[Mike Hoye [:mhoye]]

Can I get a source URL for this fix?

Comment 2

[[e-mail]]

This issue is bound to screen_lock & screen_lock_passcode.html
https://github.com/mozilla-b2g/gaia/tree/master/apps/settings/elements

Feel free to create new bug and remove strings in relative panels.

FYR: l10n best practices
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1195709_remove_screenlock_panel_string > mozilla-b2g:master

Comment 4

[Dan Huang[:danhuang]]

Comment on attachment 8650838 [details] [review]
[gaia] danhuang1202:1195709_remove_screenlock_panel_string > mozilla-b2g:master

Please help to review. I had removed tag string with i10n attr in screen_lock.html and screen_lock_passcode.html. Thanks.

Comment 5

[[e-mail]]

Comment on attachment 8650838 [details] [review]
[gaia] danhuang1202:1195709_remove_screenlock_panel_string > mozilla-b2g:master

Thanks! Now you can merge the commit.

Comment 6

[Dan Huang[:danhuang]]

Thanks for the review.

Comment 7

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/f6cde6b8a2af2d2cfa3ce9b7f4cda2daab9174a8

congrats for first gaia commit!