Closed Bug 1195732 Opened 5 years ago Closed 5 years ago

Intermittent Talos AttributeError: 'ProcessHandler' object has no attribute 'returncode'

Categories

(Testing :: Talos, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(firefox41 unaffected, firefox42 unaffected, firefox43 fixed, firefox-esr38 unaffected)

RESOLVED FIXED
mozilla43
Tracking Status
firefox41 --- unaffected
firefox42 --- unaffected
firefox43 --- fixed
firefox-esr38 --- unaffected

People

(Reporter: RyanVM, Assigned: parkouss)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

No description provided.
interesting, looking at mozprocess.processhandler:
https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozprocess/mozprocess/processhandler.py

It is hard to tell, but self.returncode is easily discoverable for the windows case, I wonder if it is discoverable for the linux case?  Either way, the base case seems to define it.

What is really odd is that it looks like we should always be hitting this code path for checking proc.returncode:
http://hg.mozilla.org/build/talos/file/c0039de7a1c6/talos/talos_process.py#l68

this makes me wonder why processhandler would not have set returncode.

:parkouss, you know a lot about mozbase and talos, maybe you have a thought which I don't have.
Flags: needinfo?(j.parkouss)
Attached patch 1195732.patch (obsolete) — Splinter Review
This should fix the issue. I forgot that ProcessHandler is a bit fragile with returncode and do not react like subprocess for that.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Flags: needinfo?(j.parkouss)
Attachment #8649356 - Flags: review?(jmaher)
Comment on attachment 8649356 [details] [diff] [review]
1195732.patch

Review of attachment 8649356 [details] [diff] [review]:
-----------------------------------------------------------------

hey, this should work!
Attachment #8649356 - Flags: review?(jmaher) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Status: RESOLVED → REOPENED
Flags: needinfo?(j.parkouss)
Resolution: FIXED → ---
Target Milestone: mozilla43 → ---
So this is normal, :jmaher backed out the fix for another reason. NI :jmaher so he can mark this as resolved once the patch is landed again.
Flags: needinfo?(j.parkouss) → needinfo?(jmaher)
working on fixing the talos issue in bug 1195288, on r+ there we can land talos again and this will be resolved.
Flags: needinfo?(jmaher)
Attached patch 1195732.patchSplinter Review
So this should fix another issue we have with that proc.returncode attribute; This is the last one remaining, so we should be good after that.

I tried locally with success, though a try would be good I think (I can do that later today).
Attachment #8649356 - Attachment is obsolete: true
Attachment #8659173 - Flags: review?(jmaher)
Comment on attachment 8659173 [details] [diff] [review]
1195732.patch

Review of attachment 8659173 [details] [diff] [review]:
-----------------------------------------------------------------

good stuff!
Attachment #8659173 - Flags: review?(jmaher) → review+
green on try, should be landed!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f6b6f8fcb039
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.