1195732 - Intermittent Talos AttributeError: 'ProcessHandler' object has no attribute 'returncode'

Ryan VanderMeulen [:RyanVM]

Reporter

Description

•

9 years ago

No description provided.

Comment hidden (Legacy TBPL/Treeherder Robot)

Joel Maher ( :jmaher ) (UTC -8)

Comment 2

•

9 years ago

interesting, looking at mozprocess.processhandler: https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozprocess/mozprocess/processhandler.py It is hard to tell, but self.returncode is easily discoverable for the windows case, I wonder if it is discoverable for the linux case? Either way, the base case seems to define it. What is really odd is that it looks like we should always be hitting this code path for checking proc.returncode: http://hg.mozilla.org/build/talos/file/c0039de7a1c6/talos/talos_process.py#l68 this makes me wonder why processhandler would not have set returncode. :parkouss, you know a lot about mozbase and talos, maybe you have a thought which I don't have.

Flags: needinfo?(j.parkouss)

Julien Pagès (:parkouss)

Assignee

Comment 3

•

9 years ago

Attached patch 1195732.patch (obsolete) — Details — Splinter Review

This should fix the issue. I forgot that ProcessHandler is a bit fragile with returncode and do not react like subprocess for that.

Assignee: nobody → j.parkouss

Status: NEW → ASSIGNED

Flags: needinfo?(j.parkouss)

Attachment #8649356 - Flags: review?(jmaher)

Joel Maher ( :jmaher ) (UTC -8)

Comment 4

•

9 years ago

Comment on attachment 8649356 [details] [diff] [review] 1195732.patch Review of attachment 8649356 [details] [diff] [review]: ----------------------------------------------------------------- hey, this should work!

Attachment #8649356 - Flags: review?(jmaher) → review+

Julien Pagès (:parkouss)

Assignee

Comment 5

•

9 years ago

Landed in https://hg.mozilla.org/build/talos/rev/306fac2f61aa.

Comment hidden (Legacy TBPL/Treeherder Robot)

Joel Maher ( :jmaher ) (UTC -8)

Updated

•

9 years ago

Blocks: 1197483

Joel Maher ( :jmaher ) (UTC -8)

Updated

•

9 years ago

Status: ASSIGNED → RESOLVED

Closed: 9 years ago

Resolution: --- → FIXED

Ryan VanderMeulen [:RyanVM]

Reporter

Updated

•

9 years ago

status-firefox41: --- → unaffected

status-firefox42: --- → unaffected

status-firefox43: --- → fixed

status-firefox-esr38: --- → unaffected

Target Milestone: --- → mozilla43

Comment hidden (Legacy TBPL/Treeherder Robot)

Ryan VanderMeulen [:RyanVM]

Reporter

Updated

•

9 years ago

Status: RESOLVED → REOPENED

status-firefox43: fixed → affected

Flags: needinfo?(j.parkouss)

Resolution: FIXED → ---

Target Milestone: mozilla43 → ---

Julien Pagès (:parkouss)

Assignee

Comment 16

•

9 years ago

So this is normal, :jmaher backed out the fix for another reason. NI :jmaher so he can mark this as resolved once the patch is landed again.

Flags: needinfo?(j.parkouss) → needinfo?(jmaher)

Joel Maher ( :jmaher ) (UTC -8)

Comment 17

•

9 years ago

working on fixing the talos issue in bug 1195288, on r+ there we can land talos again and this will be resolved.

Flags: needinfo?(jmaher)

Comment hidden (Legacy TBPL/Treeherder Robot)

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=13464154 repository: mozilla-inbound start_time: 2015-08-29T17:09:14 who: rvandermeulen[at]mozilla[dot]com machine: t-w864-ix-062 buildname: Windows 8 64-bit mozilla-inbound pgo talos g2-e10s revision: 10592387dea4 Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Full message: TypeError: this.traits is undefined Full message: TypeError: this.traits is undefined Full message: TypeError: this.traits is undefined Message: TypeError: this.traits is undefined Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Handler function threw an exception: TypeError: can't access dead object Traceback (most recent call last): AttributeError: 'ProcessHandler' object has no attribute 'returncode' Return code: 1 No talos data in output! # TBPL WARNING #

Comment hidden (Legacy TBPL/Treeherder Robot)

Julien Pagès (:parkouss)

Assignee

Comment 60

•

9 years ago

Attached patch 1195732.patch — Details — Splinter Review

So this should fix another issue we have with that proc.returncode attribute; This is the last one remaining, so we should be good after that. I tried locally with success, though a try would be good I think (I can do that later today).

Attachment #8649356 - Attachment is obsolete: true

Attachment #8659173 - Flags: review?(jmaher)

Joel Maher ( :jmaher ) (UTC -8)

Comment 61

•

9 years ago

Comment on attachment 8659173 [details] [diff] [review] 1195732.patch Review of attachment 8659173 [details] [diff] [review]: ----------------------------------------------------------------- good stuff!

Attachment #8659173 - Flags: review?(jmaher) → review+

Comment hidden (Legacy TBPL/Treeherder Robot)

Julien Pagès (:parkouss)

Assignee

Comment 65

•

9 years ago

pushed on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba38bdc52e1d

Comment hidden (Legacy TBPL/Treeherder Robot)

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=13932996 repository: mozilla-inbound start_time: 2015-09-10T19:25:53 who: philringnalda[at]gmail[dot]com machine: t-w864-ix-062 buildname: Windows 8 64-bit mozilla-inbound talos g2 revision: 9680bd9d3a6d 2015-09-10 19:36:18,243 DEBUG : BROWSER_OUTPUT: Full message: TypeError: this.traits is undefined 2015-09-10 19:36:18,282 DEBUG : BROWSER_OUTPUT: Full message: TypeError: this.traits is undefined 2015-09-10 19:36:18,302 DEBUG : BROWSER_OUTPUT: Full message: TypeError: this.traits is undefined 2015-09-10 19:36:18,322 DEBUG : BROWSER_OUTPUT: Message: TypeError: this.traits is undefined 2015-09-10 19:37:22,315 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:37:22,316 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:37:22,328 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:37:22,329 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:37:22,335 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:37:22,336 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:37:22,336 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:37:22,368 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:37:25,440 DEBUG : BROWSER_OUTPUT: Full message: TypeError: this.traits is undefined 2015-09-10 19:37:25,513 DEBUG : BROWSER_OUTPUT: Full message: TypeError: this.traits is undefined 2015-09-10 19:37:25,532 DEBUG : BROWSER_OUTPUT: Full message: TypeError: this.traits is undefined 2015-09-10 19:37:25,552 DEBUG : BROWSER_OUTPUT: Message: TypeError: this.traits is undefined 2015-09-10 19:38:42,625 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,625 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,644 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,650 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,650 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,733 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,783 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,789 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,793 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,796 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,801 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,802 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,806 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:38:42,812 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,322 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,322 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,332 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,351 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,361 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,371 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,377 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,417 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,418 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,460 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,500 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,535 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,536 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:39:17,540 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,200 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,200 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,200 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,220 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,269 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,299 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,305 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,313 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,352 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,398 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,400 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,426 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,427 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:33,427 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null 2015-09-10 19:42:52,996 DEBUG : BROWSER_OUTPUT: Handler function NRL_getSecurityInfo threw an exception: TypeError: this.transport is null Traceback (most recent call last): AttributeError: 'ProcessHandler' object has no attribute 'returncode' Return code: 1 TALOSDATA was seen 0 times, expected 1. # TBPL WARNING #

Comment hidden (Legacy TBPL/Treeherder Robot)

Julien Pagès (:parkouss)

Assignee

Comment 86

•

9 years ago

green on try, should be landed!

Keywords: checkin-needed

Comment hidden (Legacy TBPL/Treeherder Robot)

Pulsebot

Comment 95

•

9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6b6f8fcb039

Keywords: checkin-needed

Phil Ringnalda (:philor)

Comment 96

•

9 years ago

https://hg.mozilla.org/mozilla-central/rev/f6b6f8fcb039

Status: REOPENED → RESOLVED

Closed: 9 years ago → 9 years ago

status-firefox43: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla43

1195732.patch 9 years ago Julien Pagès (:parkouss) 1.26 KB, patch	jmaher : review+	Details \| Diff \| Splinter Review
1195732.patch 9 years ago Julien Pagès (:parkouss) 1.28 KB, patch	jmaher : review+	Details \| Diff \| Splinter Review