Intermittent Talos AttributeError: 'ProcessHandler' object has no attribute 'returncode'

RESOLVED FIXED in Firefox 43

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: parkouss)

Tracking

({intermittent-failure})

unspecified
mozilla43
x86_64
Linux
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox41 unaffected, firefox42 unaffected, firefox43 fixed, firefox-esr38 unaffected)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Comment hidden (Treeherder Robot)
interesting, looking at mozprocess.processhandler:
https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozprocess/mozprocess/processhandler.py

It is hard to tell, but self.returncode is easily discoverable for the windows case, I wonder if it is discoverable for the linux case?  Either way, the base case seems to define it.

What is really odd is that it looks like we should always be hitting this code path for checking proc.returncode:
http://hg.mozilla.org/build/talos/file/c0039de7a1c6/talos/talos_process.py#l68

this makes me wonder why processhandler would not have set returncode.

:parkouss, you know a lot about mozbase and talos, maybe you have a thought which I don't have.
Flags: needinfo?(j.parkouss)
(Assignee)

Comment 3

3 years ago
Created attachment 8649356 [details] [diff] [review]
1195732.patch

This should fix the issue. I forgot that ProcessHandler is a bit fragile with returncode and do not react like subprocess for that.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Flags: needinfo?(j.parkouss)
Attachment #8649356 - Flags: review?(jmaher)
Comment on attachment 8649356 [details] [diff] [review]
1195732.patch

Review of attachment 8649356 [details] [diff] [review]:
-----------------------------------------------------------------

hey, this should work!
Attachment #8649356 - Flags: review?(jmaher) → review+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
status-firefox41: --- → unaffected
status-firefox42: --- → unaffected
status-firefox43: --- → fixed
status-firefox-esr38: --- → unaffected
Target Milestone: --- → mozilla43
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Reporter)

Updated

3 years ago
Status: RESOLVED → REOPENED
status-firefox43: fixed → affected
Flags: needinfo?(j.parkouss)
Resolution: FIXED → ---
Target Milestone: mozilla43 → ---
(Assignee)

Comment 16

3 years ago
So this is normal, :jmaher backed out the fix for another reason. NI :jmaher so he can mark this as resolved once the patch is landed again.
Flags: needinfo?(j.parkouss) → needinfo?(jmaher)
working on fixing the talos issue in bug 1195288, on r+ there we can land talos again and this will be resolved.
Flags: needinfo?(jmaher)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 60

3 years ago
Created attachment 8659173 [details] [diff] [review]
1195732.patch

So this should fix another issue we have with that proc.returncode attribute; This is the last one remaining, so we should be good after that.

I tried locally with success, though a try would be good I think (I can do that later today).
Attachment #8649356 - Attachment is obsolete: true
Attachment #8659173 - Flags: review?(jmaher)
Comment on attachment 8659173 [details] [diff] [review]
1195732.patch

Review of attachment 8659173 [details] [diff] [review]:
-----------------------------------------------------------------

good stuff!
Attachment #8659173 - Flags: review?(jmaher) → review+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 86

3 years ago
green on try, should be landed!
Keywords: checkin-needed
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
https://hg.mozilla.org/mozilla-central/rev/f6b6f8fcb039
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.