Closed Bug 1195860 Opened 6 years ago Closed 6 years ago
Change "Ship It" and "Publish" buttons/links to clarify behavior
40 bytes, text/x-review-board-request
The buttons within MozReview can be quite confusing. "Review" could be considered a noun or a verb, and in the buttons at the top of the page it is used as a verb, but clicking "Review" doesn't actually let you "review" the code, it allows you to finalize the review and append some general comments. Whereas "Ship it!" also finalizes the review but doesn't provide an area for general comments. I think "review" doesn't grant r+ but I can't remember if there is the ability to grant it from there as well. These two should probably be merged. I would suggest removing "ship it!" and changing the "review" name to "finalize review...".
That's a pretty good idea. I wonder how many people would miss having a single button to ship it/r+, though... I guess we could try. :)
Priority: -- → P2
I'll take this.
Assignee: nobody → gps
Status: NEW → ASSIGNED
mozreview: consolidate buttons for publishing reviews (bug 1195860); r?mdoglio The review request page currently has many buttons/links related to publishing/submitting review: 1) A "Review" text link in the actions list that opens the review dialog. 2) A "Ship It" text link in the actions list that submits the current review and marks it as ship it. 3) A "Edit Review" button in the review banner that opens the review dialog. 4) A "Publish" button in the review banner that publishes the review as-is, with no dialog for confirmation. The redundancy in buttons and subtle nuances in behavior are confusing. Many are confused what each button does. "Does it open a dialog for additional confirmation or not?" "Why are there multiple review buttons." "Reviews is a noun but it seems to perform an action." This commit attempts to reduce confusion by: 1) Removing the "Publish" and "Ship It" buttons. 2) Changing the text of "Edit Review" to "Finish Review" so people have a hint that clicking it will finalize the review. 3) Changing the text of "Review" to "Finish Review" so it is a verb (like other text in the actions list) and so it matches the text in the review banner. The new UI is simpler and consistent. The simplicity does come at a price: power users no longer can click a single button to publish or ship it a review. Instead, they must open the review dialog and click "Publish Review" there. Since many new users were confused by the various buttons, I think this trade-off is acceptable. If people miss the old functionality, we can always add it back in somehow, preferably with better UI to indicate what exactly is going to happen. For now, we favor simplicity.
Attachment #8653261 - Flags: review?(mdoglio)
Attachment #8653261 - Flags: review?(mdoglio) → review+
Comment on attachment 8653261 [details] MozReview Request: mozreview: consolidate buttons for publishing reviews (bug 1195860); r?mdoglio https://reviewboard.mozilla.org/r/17401/#review15529 Ship It!
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Summary: "Ship it!" doesn't provide the ability to add a general comment like "Review" does → Change "Ship It" and "Publish" buttons/links to clarify behavior
You need to log in before you can comment on or make changes to this bug.