1195869 - Refresh tabs in sidebar mode

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The sidebar mode has a known issue[1] with refreshing device tabs:

    // There are currently no available events to listen for when an unselected
    // tab navigates.  Since we show every tab's location in the project menu,
    // we re-list all the tabs each time the menu is displayed.
    // TODO: An event-based solution will be needed for the sidebar UI.

Since we're no longer clicking a button to show the project list in sidebar mode, there's no click event we can use as a signal to re-request updated tab info.

Let's try either a small refresh button next to the tabs header, or something similar to this, to resolve the issue in sidebar mode.

[1]: https://dxr.mozilla.org/mozilla-central/source/browser/devtools/webide/content/webide.js#1108

Comment 1

[Jen Fong-Adwent [:ednapiranha]]

Attachment: Bug1195869.patch

This seems to work. I'm unsure about my wording in the comment for showProjectPanel about removing that check if/when the dropdown mode is removed - if you have any suggestions on better wording, feel free to suggest one. 

Otherwise, let me know if that looks good. Uploading a screenshot next.

Comment 2

[Jen Fong-Adwent [:ednapiranha]]

Attachment: Firefox_WebIDE.png

Screenshot of new refresh tab button

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8650106 [details]
Firefox_WebIDE.png

WFM!

(Could we set default icons for tabs/projects that don't have any?)

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8650105 [details] [diff] [review]
Bug1195869.patch

Review of attachment 8650105 [details] [diff] [review]:
-----------------------------------------------------------------

Overall I think it looks good!  The comment seems fine.

I'm with Alex though: can we make sure there are default icons?  It looks like tweaking `updateTabs` may do it.

Comment 5

[Jen Fong-Adwent [:ednapiranha]]

Attachment: Bug1195869.patch

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b149643ba5b

Comment 6

[Jen Fong-Adwent [:ednapiranha]]

One thing to note is that running this in localruntime mode will result in an invalid favicon but a valid url.origin (chrome://webide).

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6aea2f75ee30

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6aea2f75ee30

Comment 9

[Francesco Lodolo [:flod]]

    9.12 +<!ENTITY projectMenu_refreshTabs_label "Refresh Tabs">
    9.13 +<!ENTITY projectMenu_refreshTabs_accesskey "U">

You set an accesskey that's not available in the label, is this wanted?

Comment 10

[Jen Fong-Adwent [:ednapiranha]]

(In reply to Francesco Lodolo [:flod] from comment #9)
>     9.12 +<!ENTITY projectMenu_refreshTabs_label "Refresh Tabs">
>     9.13 +<!ENTITY projectMenu_refreshTabs_accesskey "U">
> 
> You set an accesskey that's not available in the label, is this wanted?

Ah, good catch! I'll follow up with that on another bug.