Closed Bug 1195942 Opened 5 years ago Closed 5 years ago

System message registration fails for substituted permissions

Categories

(Core Graveyard :: DOM: Apps, defect)

defect
Not set
normal

Tracking

(feature-b2g:2.2r?, firefox43 fixed)

RESOLVED FIXED
mozilla43
feature-b2g 2.2r?
Tracking Status
firefox43 --- fixed

People

(Reporter: fabrice, Assigned: fabrice)

Details

Attachments

(1 file)

the isSystemMessagePermittedToRegister() method at https://mxr.mozilla.org/mozilla-central/source/dom/messages/SystemMessagePermissionsChecker.jsm?rev=8a0408f87f96#226 doesn't take into account the 'substitute' property in the permission table. That means that we reject some system message registration that we should accept.
Assignee: nobody → fabrice
Green try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=66805d9ac2d3

We always set the permissions before registering system messages so I changed to a simpler solution where we actually end up querying the permission manager.
Attachment #8649585 - Flags: review?(anygregor)
Attachment #8649585 - Flags: review?(anygregor) → review+
https://hg.mozilla.org/mozilla-central/rev/9b7811028a40
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
feature-b2g: --- → 2.2r?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.