Remove #ifdefs from browser/components/tabview JS files

RESOLVED FIXED in Firefox 43

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Gijs, Assigned: aryx)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 43

Details

Attachments

(1 attachment)

Hits:

browser/components/tabview/search.js:#ifdef XP_MACOSX
browser/components/tabview/search.js:#endif
browser/components/tabview/search.js:#ifdef XP_MACOSX
browser/components/tabview/search.js:#endif
browser/components/tabview/ui.js:#ifdef XP_MACOSX
browser/components/tabview/ui.js:#endif
browser/components/tabview/ui.js:#ifdef XP_MACOSX
browser/components/tabview/ui.js:#endif
browser/components/tabview/ui.js:#ifdef XP_MACOSX
browser/components/tabview/ui.js:#endif
browser/components/tabview/ui.js:#ifdef XP_UNIX
browser/components/tabview/ui.js:#else
browser/components/tabview/ui.js:#endif
browser/components/tabview/ui.js:#ifdef XP_MACOSX
browser/components/tabview/ui.js:#endif
browser/components/tabview/ui.js:#ifdef XP_UNIX
browser/components/tabview/ui.js:#endif
browser/components/tabview/ui.js:#ifdef XP_MACOSX
browser/components/tabview/ui.js:#endif
browser/components/tabview/ui.js:#ifdef XP_MACOSX
browser/components/tabview/ui.js:#else
browser/components/tabview/ui.js:#endif

All of these are available on AppConstants.jsm
Created attachment 8650447 [details] [diff] [review]
patch, v1
Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
Attachment #8650447 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8650447 [details] [diff] [review]
patch, v1

Review of attachment 8650447 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nits below fixed & assuming green try

::: browser/components/tabview/search.js
@@ +597,1 @@
>        UI.setTitlebarColors({active: "#717171", inactive: "#EDEDED"});

Nit: It looks like this isn't a diff -w, which means both these lines need indenting

::: browser/components/tabview/ui.js
@@ +988,5 @@
>          if (evt.altKey)
>            return;
>  
> +        if ((AppConstants.platform == "macosx" && evt.metaKey) ||
> +            (!(AppConstants.platform == "macosx") && evt.ctrlKey))

Nit: (AppConstants.platform != "macosx" && evt.ctrlKey)

@@ +989,5 @@
>            return;
>  
> +        if ((AppConstants.platform == "macosx" && evt.metaKey) ||
> +            (!(AppConstants.platform == "macosx") && evt.ctrlKey))
> +        {

Nit: on the previous line at the end, not on its own line
Attachment #8650447 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/14e16174289b
https://hg.mozilla.org/mozilla-central/rev/14e16174289b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.