Closed Bug 1196032 Opened 5 years ago Closed 5 years ago
Search suggestions opt-in in the urlbar should not appear in private windows
Search suggestions in the urlbar are disabled in private windows, so the opt-in notification should not be shown there.
Marco, not sure how available you are to do reviews right now, but I'll give it a shot. :-)
Attachment #8649563 - Flags: review?(mak77)
Comment on attachment 8649563 [details] [diff] [review] patch Review of attachment 8649563 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/general/browser_urlbarSearchSuggestionsNotification.js @@ +139,5 @@ > + gURLBar.blur(); > + gURLBar.focus(); > + yield promiseAutocompleteResultPopup("foo"); > + assertVisible(true); > + gURLBar.blur(); is this whole check really needed? I assume the other tests are already checking that the notification is visible in a normal window...
Attachment #8649563 - Flags: review?(mak77) → review+
Yeah, fair enough, I landed without it. https://hg.mozilla.org/integration/fx-team/rev/eba63213016d
Approval Request Comment [Feature/regressing bug #]: Search suggestions opt-in notification in the urlbar [User impact if declined]: The opt-in will incorrectly and confusingly appear in private windows. [Describe test coverage new/current, TreeHerder]: New automated test [Risks and why]: Very low risk, minor one-line change with automated and manual test coverage [String/UUID change made/needed]: None
Attachment #8650720 - Flags: approval-mozilla-aurora?
Comment on attachment 8650720 [details] [diff] [review] Aurora/42 patch (same as patch that landed on fx-team/m-c) Thanks for the tests! Taking it.
Attachment #8650720 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed using Developer Edition 42.0a2 and Nightly 43.0a1 both 2015-08-23 under Win 7 64-bit, Ubuntu 14.04 and Mac OS X 10.9.5.
You need to log in before you can comment on or make changes to this bug.