1196036 - Port update manager check box to use web components

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

It's one of the few remaining checkboxes in the system app to port.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1196036_update_manager_checkbox > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8649617 [details] [review]
[gaia] KevinGrandon:bug_1196036_update_manager_checkbox > mozilla-b2g:master

Alex - if you have time I think you would make a good reviewer for this patch as I think you might be one of the few people who would actually test the update flow. No worries if you don't, just let me know and I will send it to a system peer. Thanks!

Comment 3

[:gerard-majax]

Kevin, sorry, but I am not a peer for this. I'll give a look and test this but I will not have the power to give you formal review :)

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8649617 [details] [review]
[gaia] KevinGrandon:bug_1196036_update_manager_checkbox > mozilla-b2g:master

(In reply to Alexandre LISSY :gerard-majax from comment #3)
> Kevin, sorry, but I am not a peer for this. I'll give a look and test this
> but I will not have the power to give you formal review :)

No worries, I think you can *technically* because I'm a peer, but flagging some peers here as well. Thanks if you can test!

Alberto - would you mind taking a look at this?

Comment 5

[Alberto Pastor [:albertopq]]

Comment on attachment 8649617 [details] [review]
[gaia] KevinGrandon:bug_1196036_update_manager_checkbox > mozilla-b2g:master

LGTM and works great. Thanks!

Comment 6

[Kevin Grandon :kgrandon]

Thanks for the review. In master: https://github.com/mozilla-b2g/gaia/commit/ddd51a064aa3e27f558216371551ac7713eddd2b

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8649617 [details] [review]
[gaia] KevinGrandon:bug_1196036_update_manager_checkbox > mozilla-b2g:master

Dogfooders should let us know soon enough if there's any bugs here, Alex - feel free to take a look if you still have time. Thanks!