1196088 - Show domain instead of title for top sites

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Richard Newman [:rnewman]]

Right now (after Bug 1194325) we show the title of the 'winner' for each domain-grouped site, but tapping it takes you to the root domain.

(That choice was made because the alternative is to pick one of the contributing URLs and go to it -- every time you go to Amazon you'd end up on the same vacuum cleaner bags page. Not good.)

I'd like to do something smarter about the target URL -- taking you to the longest-common-sub-URL, so {wiki.mozilla.org/mobile/foo/bar, wiki.mozilla.org/mobile/} => wiki.mozilla.org/mobile/ rather than wiki.mozilla.org/ -- but that's another bug.

In the mean time, I think it'd be cleaner to show just the domain in top sites. Mine show all kinds of random shit, like:

1195133 - Domai…
wild boys duran a…
+ #mobile | Mozilla
AmazonSmile Th…
(5) Twitter

when it could be showing

bugzilla.mozilla.org
duckduckgo.com
irccloud.mozilla.com
smile.amazon.com
twitter.com

That's exactly what desktop does; it's cleaner; and it shows the URL that tapping the tile will actually take you to.

Robin, thoughts?

Comment 1

[Robin Andersen [:tecgirl]]

GFI! Obviously cleaner, less random shit.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Pull req.

Robin: there's a screenshot on the PR.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8649986 [details] [review]
Pull req.

Darrin ui-reviewed on GitHub.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8649986 [details] [review]
Pull req.

LGTM

Comment 5

[Richard Newman [:rnewman]]

a4a24a2