Closed Bug 1196093 Opened 9 years ago Closed 9 years ago

support http auth for delivering reports to sentry

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set
major

Tracking

()

RESOLVED WONTFIX

People

(Reporter: glob, Assigned: glob)

Details

Attachments

(1 file)

sentry has just been put behind http auth, so we'll need to add parameters to store ldap credentials and update sentry.pl to perform basic http auth when submitting reports.
Attached patch 1196093_1.patchSplinter Review
Assignee: nobody → glob
Attachment #8649660 - Flags: review?(dkl)
Comment on attachment 8649660 [details] [diff] [review]
1196093_1.patch

Review of attachment 8649660 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine and works as expected. r=dkl

::: sentry.pl
@@ +88,5 @@
> +    package RequestAgent;
> +    use parent 'LWP::UserAgent';
> +
> +    sub get_basic_credentials {
> +        return Bugzilla->params->{sentry_username}

Should we check that both are filled in?
Attachment #8649660 - Flags: review?(dkl) → review+
this is no longer required - the http auth requirements have been removed from report submission.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: