Closed Bug 1196132 Opened 9 years ago Closed 9 years ago

Switching to remote tabs panel sometimes results in a jarring pull-down animation before loading the panel

Categories

(Firefox for iOS :: Browser, defect)

Product:
Firefox for iOS
Component:
Browser
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 1.1+ ---

People

(Reporter: bmunar, Assigned: fluffyemily)

Details

Attachments

(1 file)

Pull request
47 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review 
      No description provided.
status-fxios-v1.1: --- → ?
tracking-fxios: --- → ?
status-fxios-v1.1: ? → ---
Attached file Pull request — 

        Attachment #8649839 -
        Flags: review?(sarentz)

    
  
Assignee: nobody → etoop
Status: NEW → ASSIGNED

        Attachment #8649839 -
        Flags: review?(sarentz) → review?(sleroux)

    
    

    
  
So oddly enough, this fixes this crash: 

https://bugzilla.mozilla.org/show_bug.cgi?id=1196276

I did some debugging and it looks like calling the beginRefresh + refresh from viewWillAppear will randomly crash the app when switching between panels fast. Not exactly sure the reasoning but this will fix it!

    
    

    
  
Comment on attachment 8649839 [details] [review]
Pull request

LGTM - I'll follow up with a patch that fixes the crash issue

        Attachment #8649839 -
        Flags: review?(sleroux) → review+

    
    

    
  
Merged
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: