1196153 - Firefox sync has two images for same purpose

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Alfred Kayser]

From bug 1149721: 
There are now two images inside FF representing almost the same thing.
sync-illustration in about:preferences and graphic_sync_intro.png in about:accounts.

I would propose to select one, and use the same for both purposes for consistency.

Whilst bug 1152385 is about moving away from "about:accounts", I expect the "about:accounts" URL will probably stay, and will need to be more in line with about:preferences#sync. Will Firefox Accounts be more than Firefox Sync, or will it be one and the same? This is all confusing for end-users...

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Ryan, how do you feel about this? It makes some sense...

Comment 2

[Ryan Feeley [:rfeeley]]

Once the user is signed in to Sync, nothing points to about:accounts. They never seen this image. I am all for removing this image, using the one in Sync, and even removing the headline (Account connected) because it's not always true when that shows.

Comment 3

[Ryan Feeley [:rfeeley]]

Attachment: Screenshot 2016-12-14 21.26.44.png

like this

Comment 4

[Edouard Oger [:eoger]]

Attachment: Bug 1196153 - Replace about:accounts Sync illustration by the one in Sync prefs.

Review commit: https://reviewboard.mozilla.org/r/102226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102226/

Comment 5

[Edouard Oger [:eoger]]

Attachment: notlogged.png

How it looks

Comment 6

[Edouard Oger [:eoger]]

Attachment: logged.png

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8823702 [details]
Bug 1196153 - Replace about:accounts Sync illustration by the one in Sync prefs.

https://reviewboard.mozilla.org/r/102226/#review102714

LGTM, thanks - please wait for Ryan to sign off on the 2 images you uploaded.

Comment 8

[Edouard Oger [:eoger]]

Comment on attachment 8823702 [details]
Bug 1196153 - Replace about:accounts Sync illustration by the one in Sync prefs.

Showed this to rfeeley at my desk, he said it's good to go.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2e48e28f677
Replace about:accounts Sync illustration by the one in Sync prefs. r=markh

Comment 10

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/d2e48e28f677

Comment 11

[Saheda Reza [:Antora]]

I have reproduced this issue on Firefox Nightly according to (2015-08-19)

Fixing bug is verified on Latest Developer Edition --Build ID:(20170224004003),User Agent: Mozilla/5.0 (Windows NT 10.0; rv:53.0) Gecko/20100101 Firefox/53.0 

Tested OS--Windows10 32bit
[testday-20170303]