1196198 - After uninstalling a default add-on panel the 4th panel is the new default

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

STR:
* Install an add-on that adds a panel to the home screen
* Make this panel the default panel
* Uninstall the add-on

Expected result:
The first panel should be the default panel.

Actual result:
The 4th panel is the new default panel.


We recently changed the default ordering of the home panels and with that made the first panel the new default panel on phones and tablets. There's probably some code running on uninstall that tries to restore the default of the old home panel order.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1196198 - Use ordered list to find new default panel. r?mhaigh

Bug 1196198 - Use ordered list to find new default panel. r?mhaigh

Comment 2

[Martyn Haigh (:mhaigh)]

Comment on attachment 8654821 [details]
MozReview Request: Bug 1196198 - Use ordered list to find new default panel. r?mhaigh

https://reviewboard.mozilla.org/r/17759/#review15981

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9af574254ea0

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8654821 [details]
MozReview Request: Bug 1196198 - Use ordered list to find new default panel. r?mhaigh

Approval Request Comment
[Feature/regressing bug #]: We updated the default order of panels in Fx42.
[User impact if declined]: After uninstalling an add-on that added a default panel the new default panel is kind of random (the 4th most of the time).
[Describe test coverage new/current, TreeHerder]: Manual testing.
[Risks and why]: Low risk. Instead of finding a new default panel in an unsorted list, we are now searching a new default panel in the sorted list of panels.
[String/UUID change made/needed]: -

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9af574254ea0

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8654821 [details]
MozReview Request: Bug 1196198 - Use ordered list to find new default panel. r?mhaigh

ok, let's do it!

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/125fb5322854

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Install wikipedia add-on, make it default and then uninstall it, "Top Sites" will appear as the default one
Verified as fixed using:
Device: Moto X (Android 4.4)
Build: Firefox for Android  43.0a1 (2015-09-06) and Firefox for Android 42.0a2 (2015-09-07)