Closed
Bug 1196253
Opened 7 years ago
Closed 7 years ago
update in-tree psutil to 3.1.1
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox43 fixed)
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: parkouss, Assigned: jmaher)
References
Details
Attachments
(1 file)
732.00 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Well for bug 1194074 we would need to use psutil from test jobs. So we updated psutil == 3.1.1, both sources and .whl files to internal pypi. It would be good to be in sync with the in-tree used version of psutil, so let's upate the in-tree version to 3.1.1.
Reporter | ||
Comment 1•7 years ago
|
||
It seems to me that this is just a matter of replacing psutil source files in (m-c)/python/psutil with the new 3.1.1 sources. Then probably do a big try push. :gps, am I missing something ?
Flags: needinfo?(gps)
Assignee | ||
Comment 2•7 years ago
|
||
just in case I pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=46e072417c41 we can use try extender if I missed anything :)
Assignee | ||
Comment 3•7 years ago
|
||
figured my try run is green, lets just review the patch.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Flags: needinfo?(gps)
Attachment #8649973 -
Flags: review?(gps)
Comment 4•7 years ago
|
||
Comment on attachment 8649973 [details] [diff] [review] update psutil in-tree to be 3.1.1 (1.0) Review of attachment 8649973 [details] [diff] [review]: ----------------------------------------------------------------- rs=gps. FWIW, previous upgrades of psutil have resulted in various forms of badness due to .pyc and compiled C extensions lingering in the source directory. Don't be surprised if this causes a little bit of pain. Probably best to land in the middle of the day when there is sheriff and developer support to triage any fire drills.
Attachment #8649973 -
Flags: review?(gps) → review+
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2eea7ab5228d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•4 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•