If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

remove the useless print_logcat function

RESOLVED FIXED

Status

Testing
Talos
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: parkouss, Assigned: parkouss)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox43 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
In run_tests.py we have a function "print_logcat" that seems useless now. I think everything related to logcat.log should be removed in the same time.
(Assignee)

Comment 1

2 years ago
Oh, bug 1048836 would go away if we fix that I think.
See Also: → bug 1048836
(Assignee)

Comment 2

2 years ago
Created attachment 8650062 [details] [diff] [review]
1196287.patch

Should be applied on top of the patch in bug 1195288.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8650062 - Flags: review?(jmaher)
Comment on attachment 8650062 [details] [diff] [review]
1196287.patch

Review of attachment 8650062 [details] [diff] [review]:
-----------------------------------------------------------------

I think there are a few other print_logcat spots in run_tests.py :)
Attachment #8650062 - Flags: review?(jmaher) → review+
(Assignee)

Comment 4

2 years ago
I did a grep on py files and did not see any (please tell me if I missed something!)

Pushed to try on the existing push (will be the second jobs):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4f3d39d4615
(Assignee)

Comment 5

2 years ago
All green, so I think we are good!

Landed in https://hg.mozilla.org/build/talos/rev/3625fcaa75ea.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Blocks: 1197483
You need to log in before you can comment on or make changes to this bug.