Edit a review reply should not have rating stars

VERIFIED FIXED in 44.2

Status

addons.mozilla.org Graveyard
Public Pages
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: Victor Carciu, Assigned: Colm O'Connor)

Tracking

unspecified
44.2

Details

(Whiteboard: [good first bug])

(Reporter)

Description

2 years ago
Prerequisites:
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0

Steps to reproduce:
1.Go to any addon and reply to a review
2.Edit the reply

Expected results:
Rating stars not available when editing a reply

Actual results:
Rating stars are available

Please see screencast for this bug : http://screencast.com/t/8uXy8jRC
Whiteboard: [good first bug]

Comment 1

2 years ago
Please CR https://github.com/mozilla/olympia/pull/719
Assignee: nobody → colm.oconnor.github
Thanks a lot Zuzel for your contribution, but Colm has been working on that for quite some time now. I should have assigned the bug to him already, I'm sorry that you wasted your time on this, my sincere apologies.

Colm's PR: https://github.com/mozilla/olympia/pull/720

Comment 3

2 years ago
Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/05e9ca4c38ca945246895bbaf919b30d66fd7efd
BUG 1196293 : Remove rating stars from edit review reply -- includes refactoring (ReviewReplyForm is now used for editing review replies instead of ReviewForm)

https://github.com/mozilla/olympia/commit/2f1da2f82c477e10c883eddfeaba9699e5f836c0
BUG 1196293 : Restore flake8 compliance.

https://github.com/mozilla/olympia/commit/5db32cdbfe5f1b1ec9fb1100f7df026166ae4a82
BUG 1196293 : Fix failing tests that were referencing IDs changed by refactor.

https://github.com/mozilla/olympia/commit/4044abb16932057f37dd310ca0f26a2881f94933
BUG 1196293 : Restore flake8 compliance.

https://github.com/mozilla/olympia/commit/bd8e42782cd62f8e757901a5f743f9972b9c4827
Merge pull request #720 from crdoconnor/master

BUG 1196293 : Remove rating stars from edit review reply
Thanks Colm for your contribution!
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: 2015-08-27 → 44.2
(Reporter)

Comment 5

2 years ago
Verified as fixed : http://screencast.com/t/Fo4pDzBsziaB
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.