Closed
Bug 1196293
Opened 9 years ago
Closed 9 years ago
Edit a review reply should not have rating stars
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
44.2
People
(Reporter: vcarciu, Assigned: colm.oconnor.github)
Details
(Whiteboard: [good first bug])
Prerequisites:
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0
Steps to reproduce:
1.Go to any addon and reply to a review
2.Edit the reply
Expected results:
Rating stars not available when editing a reply
Actual results:
Rating stars are available
Please see screencast for this bug : http://screencast.com/t/8uXy8jRC
Updated•9 years ago
|
Whiteboard: [good first bug]
Comment 1•9 years ago
|
||
Updated•9 years ago
|
Assignee: nobody → colm.oconnor.github
Comment 2•9 years ago
|
||
Thanks a lot Zuzel for your contribution, but Colm has been working on that for quite some time now. I should have assigned the bug to him already, I'm sorry that you wasted your time on this, my sincere apologies.
Colm's PR: https://github.com/mozilla/olympia/pull/720
Comment 3•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/olympia
https://github.com/mozilla/olympia/commit/05e9ca4c38ca945246895bbaf919b30d66fd7efd
BUG 1196293 : Remove rating stars from edit review reply -- includes refactoring (ReviewReplyForm is now used for editing review replies instead of ReviewForm)
https://github.com/mozilla/olympia/commit/2f1da2f82c477e10c883eddfeaba9699e5f836c0
BUG 1196293 : Restore flake8 compliance.
https://github.com/mozilla/olympia/commit/5db32cdbfe5f1b1ec9fb1100f7df026166ae4a82
BUG 1196293 : Fix failing tests that were referencing IDs changed by refactor.
https://github.com/mozilla/olympia/commit/4044abb16932057f37dd310ca0f26a2881f94933
BUG 1196293 : Restore flake8 compliance.
https://github.com/mozilla/olympia/commit/bd8e42782cd62f8e757901a5f743f9972b9c4827
Merge pull request #720 from crdoconnor/master
BUG 1196293 : Remove rating stars from edit review reply
Comment 4•9 years ago
|
||
Thanks Colm for your contribution!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: 2015-08-27 → 44.2
Reporter | ||
Comment 5•9 years ago
|
||
Verified as fixed : http://screencast.com/t/Fo4pDzBsziaB
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•