Closed Bug 1196317 Opened 4 years ago Closed 4 years ago
Object::m Creation Stack (and the stack it holds) shows up all over the CC graph
I'm seeing 10x CC graph size at least in one of my FF profiles, and it is all about CallbackObject objects being roots and they holding SavedFrame objects. We need to unmark gray CallbackObject::mCreationStack at some point, so that it isn't gray when CC creates the graph.
unmark gray == ExposeObjectToActiveJS
CYCLE_COLLECTOR_VISITED_GCED telemetry does show a significant spike.
This cuts the very base level CC graph size I see in non-e10s FF from 1400 to 850. (the graph size gets easily larger when loading actual web pages with event listeners and timers) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2d87f05a4a2 Approval Request Comment [Feature/regressing bug #]: bug 1148593 [User impact if declined]: higher cycle collection times [Describe test coverage new/current, TreeHerder]: about to be reviewed/land [Risks and why]: Should be safe, given that we just mark certainly alive JS stuff certainly alive from cycle collections point of view [String/UUID change made/needed]: NA
Attachment #8650392 - Flags: review?(continuation) → review+
Comment on attachment 8650392 [details] [diff] [review] patch Ok, is there a way to test this change?
Attachment #8650392 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
no any easy way currently. I think we actually should add some helper code to CC graph analysis in tests.
Cycle collector telemetry had a lot of improvements the day this landed, including max pause and total time spent in the CC: http://alerts.telemetry.mozilla.org/index.html#/detectors/1/metrics/549/alerts/?from=2015-08-24&to=2015-08-24 http://alerts.telemetry.mozilla.org/index.html#/detectors/1/metrics/683/alerts/?from=2015-08-24&to=2015-08-24
You need to log in before you can comment on or make changes to this bug.