Closed Bug 1196317 Opened 4 years ago Closed 4 years ago

CallbackObject::mCreationStack (and the stack it holds) shows up all over the CC graph

Categories

(Core :: DOM: Core & HTML, defect)

36 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

I'm seeing 10x CC graph size at least in one of my FF profiles, and it is all about
CallbackObject objects being roots and they holding SavedFrame objects.

We need to unmark gray CallbackObject::mCreationStack at some point, so that it isn't
gray when CC creates the graph.
unmark gray == ExposeObjectToActiveJS
CYCLE_COLLECTOR_VISITED_GCED telemetry does show a significant spike.
Assignee: nobody → bugs
Attached patch patchSplinter Review
This cuts the very base level CC graph size I see in non-e10s FF from 1400 to 850.
(the graph size gets easily larger when loading actual web pages with event listeners and timers)


https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2d87f05a4a2


Approval Request Comment
[Feature/regressing bug #]: bug 1148593
[User impact if declined]: higher cycle collection times
[Describe test coverage new/current, TreeHerder]: about to be reviewed/land
[Risks and why]: Should be safe, given that we just mark certainly alive JS stuff certainly alive from cycle collections point of view
[String/UUID change made/needed]: NA
Attachment #8650392 - Flags: review?(continuation)
Attachment #8650392 - Flags: approval-mozilla-aurora?
Attachment #8650392 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/be1be73acdd6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment on attachment 8650392 [details] [diff] [review]
patch

Ok, is there a way to test this change?
Attachment #8650392 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
no any easy way currently. I think we actually should add some helper code to CC graph analysis in tests.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.