1196341 - "Filter headers" doesn't work in FF 41 beta

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect)

Description

[Kostas]

in a clean FF profile 41.0b2 x64: 
- open 'Developer Tools'|Network
- open any page, https://www.mozilla.org/en-US/
- Switch to Network's 'HTML' tab and click on the html entry
- then type 'cache' inside the 'Filter headers'.

Result: filtering doesn't work.
(it also doesn't work in FF 42 Dev and Nightly 43)

In Firefox 40.0.2 it works ok.

Comment 1

[Loic]

Regression range:

good=2015-05-27
bad=2015-05-28
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ff2e07228041&tochange=baa9c64fea6f

Suspected:
Alexandre Poirot — Bug 1023386 - Split and filter properties remotely for objects. r=past

Comment 2

[Sami Jaktholm]

Attachment: bug-1196341-netmonitor-header-filtering.patch

Here's a patch that fixes the issue. The header view does not have a controller and since _doSearch() tries to access a controller method, it'll throw and fail.

Added a simple xpcshell-test to test it too.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27fbf0d220d1

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8651404 [details] [diff] [review]
bug-1196341-netmonitor-header-filtering.patch

Review of attachment 8651404 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks a lot. And there even is a test!

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracking this regression.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/731d8351c98d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/731d8351c98d

Comment 7

[Sami Jaktholm]

Comment on attachment 8651404 [details] [diff] [review]
bug-1196341-netmonitor-header-filtering.patch

Approval Request Comment
[Feature/regressing bug #]: Regression from bug 1023386.
[User impact if declined]: Filtering for Network Monitor detail tabs won't work.
[Describe test coverage new/current, TreeHerder]: VariablesView is used throughout the Developer Tools and thus it is tested in many different settings. This patch also contains a regression test for this specific test case.
[Risks and why]: Minimal. This patch adds a null-check which causes the original filtering code (before bug 1023386) to do the filtering instead of throwing an exception and failing completely. The worst case scenario is that the old filtering codepath has been broken in the meantime meaning that this bug would still be present.
[String/UUID change made/needed]: N/A

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Kostas, could you please verify the fix on the latest Nightly build whenever you get a chance? Thanks.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8651404 [details] [diff] [review]
bug-1196341-netmonitor-header-filtering.patch

The fix seems very simple and safe to uplift to Beta41 and Aurora42. Patch also includes automated tests which is great!

Comment 10

[Kostas]

(In reply to Ritu Kothari (:ritu) from comment #8)
> Kostas, could you please verify the fix on the latest Nightly build whenever
> you get a chance? Thanks.
Yes, it's working with today's Nightly x64.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Thanks Kostas! Based on comment 10, changing bug status to "Verified".

Comment 12

[Loic]

Fixed for me with the latest Nightly on Win 7 with both non-e10s/e10s mode.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/affe675fc3c6

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3b1c705d2c53