Closed Bug 1196371 Opened 4 years ago Closed 4 years ago

Runtime assert against illegal quota characters in string-valued OriginAttributes

Categories

(Core :: Security: CAPS, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

Followup from bug 1172080 comment 50.

This case is extremely unlikely, but could screw up persistent data if we get it wrong.
Attachment #8650015 - Flags: review?(michael)
Comment on attachment 8650015 [details] [diff] [review]
Add a runtime assertion against illegal string characters in OriginAttributes suffix creation. v1

Review of attachment 8650015 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8650015 - Flags: review?(Jan.Varga) → review+
Attachment #8650015 - Flags: review?(michael) → review+
Whoops, missed a windows-only ifdef.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c2cee0fae3d
Flags: needinfo?(bobbyholley)
https://hg.mozilla.org/mozilla-central/rev/aba7c1ed84b0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.