Closed
Bug 1196371
Opened 9 years ago
Closed 9 years ago
Runtime assert against illegal quota characters in string-valued OriginAttributes
Categories
(Core :: Security: CAPS, defect)
Core
Security: CAPS
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
4.86 KB,
patch
|
janv
:
review+
nika
:
review+
|
Details | Diff | Splinter Review |
Followup from bug 1172080 comment 50. This case is extremely unlikely, but could screw up persistent data if we get it wrong.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8650015 -
Flags: review?(Jan.Varga)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8650015 -
Flags: review?(michael)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8650015 [details] [diff] [review] Add a runtime assertion against illegal string characters in OriginAttributes suffix creation. v1 Review of attachment 8650015 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8650015 -
Flags: review?(Jan.Varga) → review+
|
||
Updated•9 years ago
|
Attachment #8650015 -
Flags: review?(michael) → review+
This apparently broke Windows builds like https://treeherder.mozilla.org/logviewer.html#?job_id=13061671&repo=mozilla-inbound Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/94a27f75c0e0
Flags: needinfo?(bobbyholley)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Whoops, missed a windows-only ifdef. https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c2cee0fae3d
Flags: needinfo?(bobbyholley)
https://hg.mozilla.org/mozilla-central/rev/aba7c1ed84b0
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•