Closed Bug 1196372 Opened 4 years ago Closed 4 years ago

make GetHWNDFor() work with proxied accessibles

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(1 file)

No description provided.
Attachment #8650016 - Flags: review?(surkov.alexander)
Comment on attachment 8650016 [details] [diff] [review]
make GetHWNDFor() work with proxied accessibles

Review of attachment 8650016 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/windows/msaa/AccessibleWrap.cpp
@@ +1343,5 @@
> +    return nullptr;
> +  }
> +
> +  // Accessibles in child processes are said to have the HWND of the window
> +  // there tab is within.

do popups live in the main process?
(In reply to alexander :surkov from comment #2)
> Comment on attachment 8650016 [details] [diff] [review]
> make GetHWNDFor() work with proxied accessibles
> 
> Review of attachment 8650016 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/windows/msaa/AccessibleWrap.cpp
> @@ +1343,5 @@
> > +    return nullptr;
> > +  }
> > +
> > +  // Accessibles in child processes are said to have the HWND of the window
> > +  // there tab is within.
> 
> do popups live in the main process?

yes
(In reply to Trevor Saunders (:tbsaunde) from comment #3)

> > do popups live in the main process?
> 
> yes

it'd be good to add a comment for that.
Attachment #8650016 - Flags: review?(surkov.alexander) → review+
https://hg.mozilla.org/mozilla-central/rev/1c0313734ccb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.