Closed Bug 1196393 Opened 7 years ago Closed 7 years ago

Install psutil into the virtualenv created by desktop_unittest.py

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
Tracking Status
firefox43 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(2 files)

Work is underway to make it available for all machines running Talos, I'd like to use it for something in Mochitests -- I think the only thing that remains is figuring out how to build a .whl that will work on our OSX 10.6 testers.
This is the .whl I generated from a 10.6 tester for upload to internal pypi
(In reply to Chris Manchester [:chmanchester] from comment #1)
> Confirming OSX 10.6 is the only problem area:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dfc5b338bd8

With comment 2 uploaded to pypi, re-triggers here are succeeding.
Bug 1196393 - Install psutil 3.1.1 in the desktop_unittests vitualenv so it will be available to desktop unittests. r=jlund
Attachment #8652568 - Flags: review?(jlund)
Attachment #8652568 - Flags: review?(jlund) → review+
Comment on attachment 8652568 [details]
MozReview Request: Bug 1196393 - Install psutil 3.1.1 in the desktop_unittests vitualenv so it will be available to desktop unittests. r=jlund

https://reviewboard.mozilla.org/r/17191/#review15411

I see win32 and win64 whl's were recently uploaded to pypi too.

::: testing/mozharness/scripts/desktop_unittest.py:259
(Diff revision 1)
> +        self.register_virtualenv_module(name='pip>=1.5')

why is this needed? I would have thought we would have 'pip' available already?
It is required because pip only prefer wheel format starting with version >= 1.5 (https://packaging.python.org/en/latest/installing.html#installing-cached-wheels).

Same kind of thing in bug 1194074 and I had some issues without that - if I remember well some win32 test machines are using an older pip by default.
(In reply to Julien Pagès from comment #6)
> It is required because pip only prefer wheel format starting with version >=
> 1.5
> (https://packaging.python.org/en/latest/installing.html#installing-cached-
> wheels).
> 
> Same kind of thing in bug 1194074 and I had some issues without that - if I
> remember well some win32 test machines are using an older pip by default.

thanks for the explanation.
https://hg.mozilla.org/mozilla-central/rev/cd9a769c5ac2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.