1196415 - cleanup the useless log messages in talos

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Julien Pagès (:parkouss)]

We should remove the useless logging/print statements - and replace print statements with logging stuff.

Comment 1

[Julien Pagès (:parkouss)]

Attachment: 1196415.patch

Example output now:

talos --develop -a tresize:tsvgm -e /usr/bin/firefox --cycles 2
mozversion INFO | application_buildid: 20150807021757
mozversion INFO | application_display_name: Firefox
mozversion INFO | application_id: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
mozversion INFO | application_name: Firefox
mozversion INFO | application_remotingname: firefox
mozversion INFO | application_vendor: Mozilla
mozversion INFO | application_version: 39.0.3
mozversion INFO | platform_buildid: 20150807021757
mozversion INFO | platform_version: 39.0.3
2015-08-23 20:00:07,162 INFO : starting webserver on 'localhost:52083'
2015-08-23 20:00:07,163 INFO : Starting test suite qm-pxp01
2015-08-23 20:00:07,163 INFO : Starting test tresize
2015-08-23 20:00:07,167 INFO : Initialising browser for tresize test...
2015-08-23 20:00:08,296 INFO : Browser initialized.
2015-08-23 20:00:08,296 INFO : Running cycle 1/2 for tresize test...
2015-08-23 20:00:19,362 INFO : Browser exited with error code: 0
2015-08-23 20:00:19,416 INFO : Running cycle 2/2 for tresize test...
2015-08-23 20:00:30,169 INFO : Browser exited with error code: 0
2015-08-23 20:00:30,249 INFO : Completed test tresize (00:00:23)
2015-08-23 20:00:30,249 INFO : Starting test tsvgm
2015-08-23 20:00:30,249 INFO : Initialising browser for tsvgm test...
2015-08-23 20:00:31,422 INFO : Browser initialized.
2015-08-23 20:00:31,422 INFO : Running cycle 1/2 for tsvgm test...
2015-08-23 20:01:30,361 INFO : Browser exited with error code: 0
2015-08-23 20:01:30,399 INFO : Running cycle 2/2 for tsvgm test...
2015-08-23 20:02:28,986 INFO : Browser exited with error code: 0
2015-08-23 20:02:29,027 INFO : Completed test tsvgm (00:01:58)
2015-08-23 20:02:29,063 INFO : Completed test suite (00:02:21)
2015-08-23 20:02:29,065 INFO : TALOSDATA: [{"talos_counters": {"Netw....}}]

Thanks for running Talos locally. Results are in ['/home/jp/dev/talos/local.out'] and ['/home/jp/dev/talos/local.json']

And with the --debug option you get more output (all the logging.debug output like browser output). Note that --debug is enable by mozharness.


Wlach, could that break the perfherder ingestion ?

Comment 2

[Joel Maher ( :jmaher ) (UTC -0800)]

Comment on attachment 8651524 [details] [diff] [review]
1196415.patch

Review of attachment 8651524 [details] [diff] [review]:
-----------------------------------------------------------------

as we print out the TALOSDATA json blob, treeherder should handle this just fine!  i would like to test xperf failures and cases where we generate no data and have graph server posting errors.

::: talos/output.py
@@ -161,5 @@
>                  # /run_tests.py#l176
>                  testname += test.extension()
>  
> -            utils.stamped_msg("Generating results file: %s" % test.name(),
> -                              "Started")

sadly enough I can decipher the failure to post to graph server messages by reading these- mostly looking for the pattern where it says no results generated.

I don't think this is critical to keep, just that we should think about debugging the random failures we see.

::: talos/run_tests.py
@@ +219,5 @@
>      # output results
>      if results_urls:
>          talos_results.output(results_urls)
>          if browser_config['develop']:
> +            print

why is there a print here?  is this leftover?

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8651524 [details] [diff] [review]
1196415.patch

This should be fine for perfherder, but please test on try before landing. :)

Comment 4

[Julien Pagès (:parkouss)]

Well, fixed the nits here, and pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=395d99e58127

Also I added another commit that put back the logcat removing, https://bitbucket.org/parkouss/talos/commits/cbea3dea9d0c63d40874461e902ee33fe07d69ba?at=default. (it was backed out along with the webserver stuff)

If try is green, I will land both.

Comment 5

[Julien Pagès (:parkouss)]

Same try as in bug 1187082 (it test both harnes and talos):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=288c117b2be8

Comment 6

[Julien Pagès (:parkouss)]

So, try is good! I will land both patches later (waiting for jmaher's approval or bug 1187082 landed)

From now I will reuse that try pushes for other experiments.

Comment 7

[Julien Pagès (:parkouss)]

So, landed in https://hg.mozilla.org/build/talos/rev/18be0ccfa48d and https://hg.mozilla.org/build/talos/rev/cbea3dea9d0c.